Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Destination: Vertica #26718

Merged
merged 17 commits into from
May 30, 2023
Merged

🎉 New Destination: Vertica #26718

merged 17 commits into from
May 30, 2023

Conversation

marcosmarxm
Copy link
Member

What

Publish #25682

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@marcosmarxm
Copy link
Member Author

marcosmarxm commented May 29, 2023

/test connector=connectors/destination-vertica

🕑 connectors/destination-vertica https://github.com/airbytehq/airbyte/actions/runs/5112636300
❌ connectors/destination-vertica https://github.com/airbytehq/airbyte/actions/runs/5112636300
🐛

Build Passed

Test summary info:

All Passed

@octavia-squidington-iii octavia-squidington-iii added connectors/destination/vertica area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

⚠ Destinations (1)

Connector Version Changelog Publish
destination-vertica 0.1.0
(not in seed)
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the cloud or oss registry, so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that you have added a metadata.yaml file and the expected registries are enabled.

@marcosmarxm
Copy link
Member Author

marcosmarxm commented May 30, 2023

/test connector=connectors/destination-vertica

🕑 connectors/destination-vertica https://github.com/airbytehq/airbyte/actions/runs/5121456495
✅ connectors/destination-vertica https://github.com/airbytehq/airbyte/actions/runs/5121456495
No Python unittests run

Build Passed

Test summary info:

All Passed

@marcosmarxm marcosmarxm merged commit 3aa0c28 into master May 30, 2023
23 checks passed
@marcosmarxm marcosmarxm deleted the marcos/publish-25682 branch May 30, 2023 14:39
marcosmarxm added a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* initial code

* added vertica md file

* added vertica svg file

* Update vertica.md

Only Full Refresh Sync supported as per this PR.

* Update vertica.md

set 12.0.x for vertica documentation

* pointing to a database running on a cluster

* Automated Commit - Formatting Changes

* adding metadata.yml file

* move icon and add changelog

* rename icon

---------

Co-authored-by: dhanjimahto <dhanji.km@simplify3x.com>
Co-authored-by: dhanjimahto <122617093+dhanjimahto@users.noreply.github.com>
Co-authored-by: rakeshsimplify3xaccount <127210710+rakeshsimplify3xaccount@users.noreply.github.com>
Co-authored-by: dhanjimahto <dhanjimahto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/vertica
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants