🐛 Source Hubspot: fix then state has explicit empty str state value

[bazarnov]

What

Resolving: https://github.com/airbytehq/oncall/issues/2148

How

• added additional checks for stream_state and "" state value, assign start_date instead
• edited expected records with updated deals and deals_pipelines stream records. The new property was added silently: "hs_num_of_associated_line_items": 1
• covered the case with unit test test_streams.test_empty_string_in_state()

✅ User Impact ✅ : Non-breaking change

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
• You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[bazarnov]

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5112843764
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5112843764
🐛 https://gradle.com/s/g777bpksmflia

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream deal_...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 41 passed, 2 skipped in 388.18s (0:06:28) ==============

[lazebnyi]

Please follow the instruction in Pre-merge Actions item or delete it at all.

[bazarnov]

Please follow the instruction in Pre-merge Actions item or delete it at all.

Done. It's removed.

[lazebnyi]

LGTM! Unit tests for new functionality required.

[bazarnov]

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5114692347
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5114692347
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py         10      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       951     85    91%
source_hubspot/source.py         67     20    70%
-------------------------------------------------
TOTAL                          1102    108    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/errors.py         10      1    90%
source_hubspot/source.py         67     14    79%
source_hubspot/streams.py       951    225    76%
-------------------------------------------------
TOTAL                          1102    247    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 42 passed, 2 skipped in 390.45s (0:06:30) ===================