New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Facebook Marketing: Add Ad Insights streams #26720
Merged
artem1205
merged 10 commits into
master
from
artem1205/source-facebook-ad-insights-streams-17238
May 30, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e67c31e
Source Facebook Marketing: Add Ad Insights streams
artem1205 4f58417
Source Facebook Marketing: update docs; bump version
artem1205 572d1c5
Source Facebook Marketing: update tests config
artem1205 284b9b7
Source Facebook Marketing: fix unit test
artem1205 5fcd286
Source Facebook Marketing: typo fix
artem1205 a181845
Source Facebook Marketing: update future_state
artem1205 37a8bed
Source Facebook Marketing: fix expected records
artem1205 cd05c41
Merge branch 'master' into artem1205/source-facebook-ad-insights-stre…
artem1205 8b59f36
Merge branch 'master' into artem1205/source-facebook-ad-insights-stre…
artem1205 8540661
Merge remote-tracking branch 'origin/artem1205/source-facebook-ad-ins…
artem1205 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
232 changes: 232 additions & 0 deletions
232
...nnectors/source-facebook-marketing/integration_tests/ads_insights_configured_catalog.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,232 @@ | ||
| { | ||
| "streams": [ | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_action_carousel_card", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_action_conversion_device", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_action_product_id", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_action_reaction", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_action_video_sound", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_action_video_type", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_action_type", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_delivery_device", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_delivery_platform", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_delivery_platform_and_device_platform", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_demographics_age", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_age_and_gender", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_demographics_country", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_demographics_dma_region", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_demographics_gender", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_dma", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_country", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_platform_and_device", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "ads_insights_region", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": [ | ||
| "full_refresh", | ||
| "incremental" | ||
| ] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "destination_sync_mode": "append" | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we testing the new streams if there's no data in our test account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have some data for all these streams. Or, more precisely, all ad Insight streams make requests to the same data, but using different "slicing" columns (like in pivot tables).
I've disable them for
basic_readtest, because we use our "live" account for testing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still test all these streams in
incrementalandfull_refreshtests