-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source LinkedIn Ads: reduce records limit for Creatives Stream #26780
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
/test connector=connectors/source-linkedin-ads
Build FailedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artem1205 is this the only stream that fails if we request 500 records?
For this customer yes. Still not sure how new Linkedin API works. |
/test connector=connectors/source-linkedin-ads
Build PassedTest summary info:
|
…tehq#26780) * Source LinkedIn Ads: reduce records limit for Creatives Stream * Source LinkedIn Ads: update comment * Source LinkedIn Ads: update docs * Source LinkedIn Ads: fix unit test
What
Resolve https://github.com/airbytehq/oncall/issues/2159
How
reduce records limit for Creatives Stream
500
->100
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
No breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.