Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source LinkedIn Ads: reduce records limit for Creatives Stream #26780

Merged
merged 4 commits into from
May 30, 2023

Conversation

artem1205
Copy link
Collaborator

What

Resolve https://github.com/airbytehq/oncall/issues/2159

How

reduce records limit for Creatives Stream 500 -> 100

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 30, 2023
@artem1205
Copy link
Collaborator Author

artem1205 commented May 30, 2023

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/5124202513
❌ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/5124202513
🐛 https://gradle.com/s/gpr7uuxcutigc

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=================== 6 failed, 32 passed, 2 skipped in 27.11s ===================

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artem1205 is this the only stream that fails if we request 500 records?

@artem1205
Copy link
Collaborator Author

For this customer yes. Still not sure how new Linkedin API works.
There was no problem with requesting limit=500 in our acceptance tests, at the same time this customer has 199 records for stream Creatives and limit=200 also raises the error.
That is why I set limit=100 only for this stream.

@artem1205
Copy link
Collaborator Author

artem1205 commented May 30, 2023

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/5125081599
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/5125081599
Python tests coverage:

Name                               Stmts   Miss  Cover
------------------------------------------------------
source_linkedin_ads/analytics.py      46      0   100%
source_linkedin_ads/__init__.py        2      0   100%
source_linkedin_ads/utils.py          91      5    95%
source_linkedin_ads/source.py         47      3    94%
source_linkedin_ads/streams.py       179     28    84%
------------------------------------------------------
TOTAL                                365     36    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 38 passed, 2 skipped in 2461.06s (0:41:01) ==================

@artem1205 artem1205 merged commit cc3ff52 into master May 30, 2023
32 checks passed
@artem1205 artem1205 deleted the artem1205/source-linkedin-OC-2159 branch May 30, 2023 19:38
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…tehq#26780)

* Source LinkedIn Ads: reduce records limit for Creatives Stream

* Source LinkedIn Ads: update comment

* Source LinkedIn Ads: update docs

* Source LinkedIn Ads: fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/linkedin-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants