Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in-app docs for select API sources #26781

Merged
merged 11 commits into from
Jun 6, 2023

Conversation

nataliekwong
Copy link
Contributor

What

Creates new in-app setup guides for:

  • Airtable
  • Amazon Ads
  • GitHub
  • Salesforce

Updates existing in-app setup guides for:

  • Google Analytics 4 (add detail about custom reports)
  • Instagram (add clarification about difference between Instagram and Facebook Marketing/Instagram Ads)
  • Hubspot (adds back in scope permissions)

Simplifies the existing doc, but does not create any in-app doc, just makes use of the OSS/Cloud tags that already exist.

  • Aircall
  • Google Search Console
  • Google Sheets

馃毃 User Impact 馃毃

Are there any breaking changes? What is the end result perceived by the user?
No breaking changes

Tagged you @sherifnada to review, but let me know if I should tag another teammate. I have a few more connectors I'll update in-app guides for, but don't want the PR to become too large

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 30, 2023
1. Click `Authenticate your Amazon Ads account`. Log in and authorize access to the Amazon account.
2. (Optional) Select **Region** to pull data from **North America (NA)**, **Europe (EU)**, **Far East (FE)**. See [Amazon Ads documentation](https://advertising.amazon.com/API/docs/en-us/info/api-overview#api-endpoints) for more details.
3. (Optional) **Start Date** can be used to generate reports starting from the specified start date in the format YYYY-MM-DD. The date should not be more than 60 days in the past. If not specified, today's date is used. The date is treated in the timezone of the processed profile.
4. (Optional) **Profile ID(s)** you want to fetch data for. A profile is an advertiser's account in a specific marketplace. See [Amazon Ads docs](https://advertising.amazon.com/API/docs/en-us/concepts/authorization/profiles) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a user i'd want to know the behavior if I don't specify this optional field. Does it pull everything or nothing?

2. (Optional) Select **Region** to pull data from **North America (NA)**, **Europe (EU)**, **Far East (FE)**. See [Amazon Ads documentation](https://advertising.amazon.com/API/docs/en-us/info/api-overview#api-endpoints) for more details.
3. (Optional) **Start Date** can be used to generate reports starting from the specified start date in the format YYYY-MM-DD. The date should not be more than 60 days in the past. If not specified, today's date is used. The date is treated in the timezone of the processed profile.
4. (Optional) **Profile ID(s)** you want to fetch data for. A profile is an advertiser's account in a specific marketplace. See [Amazon Ads docs](https://advertising.amazon.com/API/docs/en-us/concepts/authorization/profiles) for more details.
5. (Optional) **State Filter** Reflects the state of the Display, Product, and Brand Campaign streams as enabled, paused, or archived. If you do not populate this field, it will be ignored completely.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain I understand this. I think it's saying that if you toggle this option, we'll sync data related to campaigns regardless of their status, otherwise not? I'm not sure honestly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to clarify.

3. (Optional) **Start Date** can be used to generate reports starting from the specified start date in the format YYYY-MM-DD. The date should not be more than 60 days in the past. If not specified, today's date is used. The date is treated in the timezone of the processed profile.
4. (Optional) **Profile ID(s)** you want to fetch data for. A profile is an advertiser's account in a specific marketplace. See [Amazon Ads docs](https://advertising.amazon.com/API/docs/en-us/concepts/authorization/profiles) for more details.
5. (Optional) **State Filter** Reflects the state of the Display, Product, and Brand Campaign streams as enabled, paused, or archived. If you do not populate this field, it will be ignored completely.
6. (Optional) **Look Back Window** The amount of days to go back in time to get the updated data from Amazon Ads
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a user I don't know why this is useful vs. start date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, reached out to GL for clarification.

docs/integrations/sources/github.inapp.md Outdated Show resolved Hide resolved
@nataliekwong
Copy link
Contributor Author

@sherifnada I accidentally merged the commits from this PR #26870 here as well. LMK if you prefer that I just close #26870 and keep this one, or keep them separate.

@nataliekwong nataliekwong merged commit e462fce into master Jun 6, 2023
17 checks passed
@nataliekwong nataliekwong deleted the natalie/google-analytics-docs branch June 6, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants