Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Freshsales: fix expected records #26785

Conversation

roman-yermilov-gl
Copy link
Collaborator

What

Contacts stream expected records do not match. Field open_deals_count now has value 2 instead of 0

How

FIx open_deals_count value to 2

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl roman-yermilov-gl self-assigned this May 30, 2023
@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented May 30, 2023

/test connector=connectors/source-freshsales

🕑 connectors/source-freshsales https://github.com/airbytehq/airbyte/actions/runs/5124782043
✅ connectors/source-freshsales https://github.com/airbytehq/airbyte/actions/runs/5124782043
Python tests coverage:

Name                            Stmts   Miss  Cover
---------------------------------------------------
source_freshsales/__init__.py       2      0   100%
source_freshsales/source.py       103      7    93%
---------------------------------------------------
TOTAL                             105      7    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 35 passed, 3 skipped in 58.63s ========================

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add link to failed action.

@roman-yermilov-gl roman-yermilov-gl merged commit 5e49c16 into master May 30, 2023
25 of 26 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-freshsales-health-check-fix-expected-records branch May 30, 2023 19:01
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Source Freshsales: fix expected records

* Update expected_records.jsonl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants