Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Hubspot: migrate to advancedAuth #26831

Merged
merged 6 commits into from Jun 1, 2023

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented May 31, 2023

What

Migrate oAuth to advancedAuth.
#26236

How

Add advanced_auth to spec.yaml.

@tolik0 tolik0 linked an issue May 31, 2023 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented May 31, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 31, 2023
@tolik0
Copy link
Contributor Author

tolik0 commented May 31, 2023

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5131678345
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5131678345
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py         10      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       951     85    91%
source_hubspot/source.py         67     20    70%
-------------------------------------------------
TOTAL                          1102    108    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/errors.py         10      1    90%
source_hubspot/source.py         67     14    79%
source_hubspot/streams.py       951    225    76%
-------------------------------------------------
TOTAL                          1102    247    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:594: The previous and actual discovered catalogs are identical.
================== 44 passed, 1 skipped in 418.18s (0:06:58) ===================

@tolik0 tolik0 requested review from lazebnyi and bazarnov May 31, 2023 13:37
@@ -66,6 +66,14 @@ connectionSpecification:
examples:
- refresh_token
airbyte_secret: true
access_token:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not implemented in OAuth flow, I think we need to stay consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@tolik0 tolik0 merged commit 7b55372 into master Jun 1, 2023
27 of 28 checks passed
@tolik0 tolik0 deleted the 26236-source-hubspot-migrate-to-advancedauth branch June 1, 2023 10:58
@tolik0 tolik0 self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Hubspot: Migrate to advancedAuth
5 participants