Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cat: fix test_catalog_has_supporte_data_types when / in stream property #26868

Merged

Conversation

alafanechere
Copy link
Contributor

What

The dpath calls with / in a field name leads to key error as dpath default separator is /. Using a more exotic separator solves the problem.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (1)

Connector Version Changelog Publish
source-railz 0.1.1
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the cloud or oss registry, so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that you have added a metadata.yaml file and the expected registries are enabled.

@alafanechere alafanechere requested a review from a team May 31, 2023 21:19
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 65.93% 🍏

alafanechere and others added 2 commits May 31, 2023 21:32
… of github.com:airbytehq/airbyte into augustin/cat/fix_test_catalog_has_supported_data_types
@alafanechere
Copy link
Contributor Author

alafanechere commented May 31, 2023

/legacy-publish connector=bases/connector-acceptance-test

🕑 Publishing the following connectors:
bases/connector-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/5138025491


Connector Version Did it publish?
bases/connector-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@alafanechere alafanechere enabled auto-merge (squash) May 31, 2023 21:52
@alafanechere alafanechere merged commit de052da into master May 31, 2023
18 checks passed
@alafanechere alafanechere deleted the augustin/cat/fix_test_catalog_has_supported_data_types branch May 31, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants