connectors-ci: add retry logic at step level #26888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnchrch
approved these changes
Jun 1, 2023
| @@ -92,9 +93,12 @@ class Step(ABC): | |||
|
|
|||
| title: ClassVar[str] | |||
| started_at: ClassVar[datetime] | |||
| retry: ClassVar[bool] = False | |||
There was a problem hiding this comment.
Lets remove the retry boolean and intead rely on max_retries solely
max_retries: ClassVar[int] = 0class ConnectorPackageInstall(Step):
max_retries = 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Some Step might require a retry logic due to transient failures.
E.G: the connector package install transiently fail due to some pip errors related to not found packages.
How
Stepabstract class has aretryattribute set to false by default and amax_retriesattribute set to 3 by default_runcall returns a failed step results_runis retried from withinrun