Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Google Ads: migrate to advancedAuth #26905

Merged

Conversation

davydov-d
Copy link
Collaborator

What

#26229

How

Replace deprecated authSpecification with advancedAuth in the connector spec

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 1, 2023

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5143975486
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5143975486
🐛 https://gradle.com/s/inmeldmkuwt5o

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
============= 1 failed, 40 passed, 1 skipped in 1703.35s (0:28:23) =============

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 2, 2023

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5154039099
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5154039099
Python tests coverage:

Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/utils.py                    65      1    98%
source_google_ads/streams.py                 195      6    97%
source_google_ads/source.py                   95      7    93%
source_google_ads/custom_query_stream.py      56      5    91%
source_google_ads/google_ads.py               83     12    86%
--------------------------------------------------------------
TOTAL                                        514     31    94%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 40 passed, 2 skipped in 708.49s (0:11:48) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 6, 2023

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5186116008
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5186116008
Python tests coverage:

Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/streams.py                 195      6    97%
source_google_ads/utils.py                    59      2    97%
source_google_ads/source.py                  100      7    93%
source_google_ads/custom_query_stream.py      56      5    91%
source_google_ads/google_ads.py               83     12    86%
--------------------------------------------------------------
TOTAL                                        513     32    94%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 40 passed, 2 skipped in 625.68s (0:10:25) ===================

@davydov-d davydov-d merged commit 618fd60 into master Jun 6, 2023
26 checks passed
@davydov-d davydov-d deleted the ddavydov/#26229-source-google-ads-migrate-to-advancedAuth branch June 6, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants