Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Jira: add expand on lead field #26920

Merged
merged 11 commits into from
Jun 7, 2023
Merged

Source Jira: add expand on lead field #26920

merged 11 commits into from
Jun 7, 2023

Conversation

jkleinkauff
Copy link
Contributor

@jkleinkauff jkleinkauff commented Jun 1, 2023

What

The current project stream is not getting information for the lead field. This PR expands the stream to lead so we will be able to use that information.

#26851

How

Expand the project stream to lead field. params["expand"] = "description,lead"

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@jkleinkauff jkleinkauff changed the title Source Jira: Expand on lead field Source Jira: add expand on lead field Jun 1, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 1, 2023
@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Jun 1, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 1, 2023
@jkleinkauff
Copy link
Contributor Author

/test connector=connectors/source-jira

@jkleinkauff
Copy link
Contributor Author

@alafanechere Hey, could you help me with this one? Thank you so much!

@alafanechere
Copy link
Contributor

@marcosmarxm / @sajarin could you please run tests on a non-forked branch?

@marcosmarxm
Copy link
Member

@sh4sh can you review and run the tests?

@sh4sh
Copy link
Contributor

sh4sh commented Jun 6, 2023

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/5190823278
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/5190823278
🐛 https://gradle.com/s/dxjrqfwk6r5ku

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream proje...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
============= 1 failed, 37 passed, 3 skipped in 893.42s (0:14:53) ==============

@marcosmarxm
Copy link
Member

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jkleinkauff please make sure to sign the CLA.

@jkleinkauff
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jkleinkauff please make sure to sign the CLA.

@marcosmarxm Just signed. Thank you !!

@jkleinkauff
Copy link
Contributor Author

Hey @sh4sh is there anything missing from my side?

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkleinkauff the contribution looks good. I need to push some changes to make test work properly. I'll publish later today.

@marcosmarxm
Copy link
Member

marcosmarxm commented Jun 7, 2023

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/5203581384
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/5203581384
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_jira/utils.py         21      0   100%
source_jira/__init__.py       2      0   100%
source_jira/source.py        47      4    91%
source_jira/streams.py      665     65    90%
---------------------------------------------
TOTAL                       735     69    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 38 passed, 3 skipped in 885.43s (0:14:45) ===================

@marcosmarxm marcosmarxm merged commit 715c595 into airbytehq:master Jun 7, 2023
37 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants