-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle command to remove gitignored files #26924
Conversation
Octavia Squidington III seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
b5efe6b
to
b802416
Compare
@cpdeethree You can see in the automated change commit that we removed the oss_registry and only the oss_registry |
.github/workflows/gradle.yml
Outdated
- name: Remove any files that have been gitignored | ||
run: git ls-files -i -c --exclude-from=.gitignore | xargs git rm --cached | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I understand the purpose of it but do you want it to be permanent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh so badly I want it to be permanent!
Here's some more context on this
https://airbytehq-team.slack.com/archives/C03VDJ4FMJB/p1685647715073319
Basically multiple times now I've
- git rm --cached airbyte-config-oss/init-oss/src/main/resources/seed/oss_registry.json
- Double checked its in the gitignore
- Removed the file from my local filesystem
- Run process resources locally
- Double check the file exists but git is not tracking it
- Merged these changes to master.
However if there exists a PR that
- Is out of date from master after the above changes (all of them)
- Has a commit that changes the oss_registry.json (some of them)
- Is merged before updating to latest. (often)
That work gets undone as the file is readded, and currently tracked files do not adhere to the gitignore 😢
63895c7
to
e92c5a1
Compare
What