Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Github: fix expected records for stream pull_request #26944

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

roman-yermilov-gl
Copy link
Collaborator

What

Expected records do not match for stream pull_requests. Amount of forks field changed to 1

How

Expected records updated for stream pull_requests

@roman-yermilov-gl roman-yermilov-gl self-assigned this Jun 2, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented Jun 2, 2023

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/5155166220
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/5155166220
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/github_schema.py    8807      0   100%
source_github/constants.py           5      0   100%
source_github/__init__.py            2      0   100%
source_github/utils.py              59      2    97%
source_github/streams.py           845     88    90%
source_github/graphql.py           167     22    87%
source_github/source.py            131     23    82%
----------------------------------------------------
TOTAL                            10016    135    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 47 passed, 5 skipped in 321.91s (0:05:21) ===================

@roman-yermilov-gl roman-yermilov-gl merged commit 4e7ab95 into master Jun 2, 2023
27 of 29 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-github-health-check branch June 2, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants