Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Zendesk Support: forced ticket metrics stream to use cursor pagination #26945

Merged

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Jun 2, 2023

What

Resolving: https://github.com/airbytehq/oncall/issues/2164

How

  • changed the way request_params() pass the page param
  • changed the way to get next_page_token due to a different response structure
  • covered the case with unit tests:
    • TestSourceZendeskSupportCursorPaginationStream.test_next_page_token[TicketMetricEvents]
    • TestSourceZendeskSupportCursorPaginationStream.test_request_params[TicketMetricEvents]

🚨 User Impact 🚨

Non-breaking change.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 2, 2023
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 2, 2023

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/5154707789
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/5154707789
Python tests coverage:

Name                                                           Stmts   Miss  Cover
----------------------------------------------------------------------------------
source_zendesk_support/__init__.py                                 2      0   100%
source_zendesk_support/streams.py                                411     40    90%
source_zendesk_support/source.py                                  57      6    89%
source_zendesk_support/ZendeskSupportAvailabilityStrategy.py      10      6    40%
----------------------------------------------------------------------------------
TOTAL                                                            480     52    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 47 passed, 5 skipped in 1805.85s (0:30:05) ==================

@bazarnov bazarnov merged commit 31879f0 into master Jun 2, 2023
24 checks passed
@bazarnov bazarnov deleted the baz/source-zendesk-support-ticket-metrrics-cursor-pagination branch June 2, 2023 12:55
@potatozerg
Copy link

Hi @bazarnov, I noticed an error with the ticket metrics table
/api/v2/ticket_metrics?start_time=1609459200&page%5Bsize%5D=100
Response Code: 503, Response Text: {
"error": {
"title": "DatabaseError",
"message": "Database timeout error"
}
}

the page[size]=100 is causing this, maybe we should remove it from the API call?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/zendesk-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants