New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Zendesk Support: forced ticket metrics
stream to use cursor pagination
#26945
🐛 Source Zendesk Support: forced ticket metrics
stream to use cursor pagination
#26945
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
/test connector=connectors/source-zendesk-support
Build PassedTest summary info:
|
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
Hi @bazarnov, I noticed an error with the ticket metrics table the page[size]=100 is causing this, maybe we should remove it from the API call? |
What
Resolving: https://github.com/airbytehq/oncall/issues/2164
How
request_params()
pass thepage
paramnext_page_token
due to a different response structureTestSourceZendeskSupportCursorPaginationStream.test_next_page_token[TicketMetricEvents]
TestSourceZendeskSupportCursorPaginationStream.test_request_params[TicketMetricEvents]
🚨 User Impact 🚨
Non-breaking change.