Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors-ci: do not run VersionCheck on nightlies #26954

Merged

Conversation

alafanechere
Copy link
Contributor

What

Version check should not run on nightly builds / master.
We don't run them on master because its a check that makes sure version is correctly incremented on files.

@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="minor tweak on dagger nightly builds pipeline"

@octavia-approvington
Copy link
Contributor

After a careful ML study,
we think this looks okay.
imagine code being okay

@octavia-approvington octavia-approvington merged commit 4aa76a4 into master Jun 2, 2023
13 checks passed
@octavia-approvington octavia-approvington deleted the augustin/skip-semver-checks-on-nightlies branch June 2, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants