Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oracle to registry #2697

Merged
merged 7 commits into from
Apr 8, 2021
Merged

add oracle to registry #2697

merged 7 commits into from
Apr 8, 2021

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented Apr 1, 2021

No description provided.

@cgardens
Copy link
Contributor Author

cgardens commented Apr 1, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/706761916
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/706761916

@cgardens
Copy link
Contributor Author

cgardens commented Apr 1, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/706861669
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/706861669

@cgardens
Copy link
Contributor Author

cgardens commented Apr 1, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/707003602
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/707003602

@cgardens
Copy link
Contributor Author

cgardens commented Apr 1, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/709142114
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/709142114

@ericsgagnon
Copy link

@cgardens

I'm not an expert in this, so I can't give a ton of feedback on if it's actually a connection configuration issue, but I've run into oracle connection timezone issues before as well. Have you tried setting ORA_SDTZ? In addition to common timzeone names, if the database's timezone is configured, I believe you can set it to 'DB_TZ' to just align the connection to the DB.
Otherwise, I think you can use timezone before establishing your connection.
TimeZone timeZone = TimeZone.getTimeZone("UTC");
TimeZone.setDefault(timeZone);
then drivermanager.getconnection...

@davinchia
Copy link
Contributor

davinchia commented Apr 7, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/724953619
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/724953619

@davinchia
Copy link
Contributor

davinchia commented Apr 7, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/724967073
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/724967073

@davinchia
Copy link
Contributor

@cgardens I took a stab at this since I was also perplexed and wasn't too successful.

You can take a look at the commit history to see what I tried.. all of which are from various stackoverflow answers.

One thing that did work for me was setting the env variable in the terminal before running the gradle command.

I ended up creating a GCP Ubuntu instance so I would not have to wait forever for the builds. It's powered off now, but feel free to use it for build purposes. The builds times were 5 mins on ubuntu vs 30 mins on Github.

@cgardens
Copy link
Contributor Author

cgardens commented Apr 8, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/727761150
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/727761150

@cgardens
Copy link
Contributor Author

cgardens commented Apr 8, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/727951849
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/727951849

@cgardens
Copy link
Contributor Author

cgardens commented Apr 8, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/728060265
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/728060265

@cgardens cgardens merged commit d649683 into master Apr 8, 2021
@cgardens cgardens deleted the cgardens/add_oracle_to_ui branch April 8, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants