Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ New Source: Gainsight-px [Low Code CDK] #26998

Merged
merged 42 commits into from
Jul 12, 2023
Merged

✨ New Source: Gainsight-px [Low Code CDK] #26998

merged 42 commits into from
Jul 12, 2023

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Jun 4, 2023 •
edited
Loading

What

Developing new connector for the source: Gainsight
Closes #3384

Resolves:
🎉 New Source: Gainsight

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

🚨 User Impact 🚨

  • No breaking changes, Just addition of new source
New Connector: Source Gainsight

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Tests

Integration & Acceptance Full Test Results

image

@btkcodedev
Initial commit
c117479
@btkcodedev
Update source_definitions.yaml
5f57abc
@btkcodedev
Update source_specs.yaml
1c7c163
@btkcodedev
change manifest
32ba4a3
@btkcodedev
fix manifest
449d557
@btkcodedev
fix schema
804c8c0
@btkcodedev
fix conflict
71d6eab
@btkcodedev
Merge branch 'gainsight' of https://github.com/btkcodedev/airbyte int…
45afd48 
…o gainsight
@btkcodedev
fix conflict
c2c2cc8
@btkcodedev
Merge branch 'airbytehq:master' into gainsight
c97303a
@btkcodedev
Merge branch 'airbytehq:master' into gainsight
58a6476
@btkcodedev
fix schema, refactor manifest, add new streams
e9aa188
@btkcodedev
add streams to docs
07d47ad
@btkcodedev
add stream users
64d1e87
@btkcodedev
Merge branch 'airbytehq:master' into gainsight
562bf76
@btkcodedev
add new stream survey_response
aeeb959
@btkcodedev
update docs
77a97cb
@btkcodedev
EOF, formatting
85e6a18
@btkcodedev
Merge branch 'master' into gainsight
b4e159c
@btkcodedev
Add new stream, Update docs
a75e496
@btkcodedev
Add new streams
d631383
@btkcodedev
Refactor Schemas
be11977
@btkcodedev
Merge branch 'airbytehq:master' into gainsight
59a5b9c
@btkcodedev
Change gainsight to gainsight-px
9a6eeff
@btkcodedev
Add spec
5c3594b
@btkcodedev
Change spec
f71ce6e
@btkcodedev
rewrite spec
d17f189
@btkcodedev
Merge branch 'airbytehq:master' into gainsight
b1649d4
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 4, 2023
@btkcodedev
Copy link
Collaborator Author

Test results: Passed state, Ready for review

image

@btkcodedev
Copy link
Collaborator Author

Please ping via slack for getting the credentials

marcosmarxm
marcosmarxm previously requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review done! Thanks for the contribution.

airbyte-integrations/connectors/source-gainsight-px/source_gainsight_px/schemas/accounts.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/source_gainsight_px/schemas/feature.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/source_gainsight_px/schemas/feature.json Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/source_gainsight_px/schemas/articles.json Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/source_gainsight_px/schemas/articles.json Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/source_gainsight_px/schemas/users.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/source_gainsight_px/manifest.yaml Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/metadata.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/metadata.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-gainsight-px/metadata.yaml Show resolved Hide resolved
@btkcodedev
Copy link
Collaborator Author

Comments resolved
Test state passed:

image

@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Jun 27, 2023
@archangelic archangelic mentioned this pull request Jul 12, 2023
Closed
@btkcodedev
Copy link
Collaborator Author

Thanks @archangelic I could see the CI is passing ✅

@archangelic
Copy link
Contributor

Everything looks good to me. Once all the checks finished, I'll merge this!

@archangelic archangelic merged commit 6792753 into airbytehq:master Jul 12, 2023
42 of 47 checks passed
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@btkcodedev @archangelic @efimmatytsin
✨ New Source: Gainsight-px [Low Code CDK] (airbytehq#26998)
d5a4526 
* Initial commit

* Update source_definitions.yaml

* Update source_specs.yaml

* change manifest

* fix manifest

* fix schema

* fix conflict

* fix conflict

* fix schema, refactor manifest, add new streams

* add streams to docs

* add stream users

* add new stream survey_response

* update docs

* EOF, formatting

* Add new stream, Update docs

* Add new streams

* Refactor Schemas

* Change gainsight to gainsight-px

* Add spec

* Change spec

* rewrite spec

* Fix Schemas, metadata

* Add pagination, fix schemas

* Add icon

* Update gainsight-px.md

* Update supportUrl to documentationUrl

Co-authored-by: Mal Hancock <mhancock@archangelic.space>

* Rename to icon.svg

* fix metedata.yaml

---------

Co-authored-by: Mal Hancock <mhancock@archangelic.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archangelic archangelic archangelic approved these changes

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/gainsight-px team/tse Technical Support Engineers
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Source: Gainsight
4 participants
@btkcodedev @archangelic @marcosmarxm @octavia-squidington-iii