Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Notion: added handing empty results in response #27073

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

darynaishchenko
Copy link
Collaborator

What

resolved: https://github.com/airbytehq/oncall/issues/2204
Sometimes notion returns response without results which leading TypeError: 'NoneType' object is not iterable.

How

Added response.json().get("results", []) to avoid type error while iterations.

@darynaishchenko darynaishchenko self-assigned this Jun 6, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/notion labels Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Jun 6, 2023

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/5190645392
✅ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/5190645392
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_notion/__init__.py       2      0   100%
source_notion/streams.py      159     17    89%
source_notion/source.py        37      5    86%
source_notion/utils.py          9      4    56%
-----------------------------------------------
TOTAL                         207     26    87%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 39 passed, 3 skipped in 124.07s (0:02:04) ===================

@darynaishchenko darynaishchenko changed the title 🐛:Source Notion: added handing empty results in response 🐛Source Notion: added handing empty results in response Jun 6, 2023
@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Jun 7, 2023

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/5201734224
✅ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/5201734224
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_notion/__init__.py       2      0   100%
source_notion/streams.py      163     17    90%
source_notion/source.py        37      5    86%
source_notion/utils.py          9      4    56%
-----------------------------------------------
TOTAL                         211     26    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 39 passed, 3 skipped in 112.16s (0:01:52) ===================

@darynaishchenko darynaishchenko merged commit 83b968a into master Jun 7, 2023
24 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-notion/oc-2204/type-error-fix branch June 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/notion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants