connectors-ci: mask secrets in GHA logs with ::add-mask:: #27087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #27088
On our connectors testing pipeline our internal
ci_credentials
library is used to download GSM secrets to file system.In the context of dagger pipeline the interaction with this library is containerized.
This library uses a
VERSION
env var to modulate it's behavior:If
VERSION=dev
:::add-mask::
logs that are used to mask secrets in GHA logsIf
VERSION != dev
:::add-mask::
to stdout to make GHA redact the secrets from the logs.We've originally set the env var to
dev
in our dagger pipeline to get secret written at the right path but we miss the secret masking capabilities while doing it.How
This PR changes
ci_credentials
and its usage in our dagger pipeline to:VERSION=dev