Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Gitlab: fail on extra columns #27150

Merged
merged 31 commits into from Jun 8, 2023

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Jun 8, 2023

What

#24555

How

  • Update stream schemas
  • Remove fail_on_extra_columns: false from the CAT config

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 8, 2023

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5210275071
❌ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5210275071
🐛 https://gradle.com/s/etga2zwuzr6rc

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: as...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Please check...
ERROR test_core.py::TestBasicRead::test_read[inputs2] - docker.errors.Contain...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
========= 3 failed, 39 passed, 3 skipped, 1 error in 414.33s (0:06:54) =========

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 8, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 8, 2023

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5211877100

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 8, 2023

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5212128315
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5212128315
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_gitlab/__init__.py       2      0   100%
source_gitlab/source.py        61      3    95%
source_gitlab/streams.py      281     15    95%
-----------------------------------------------
TOTAL                         344     18    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 44 passed, 2 skipped in 562.27s (0:09:22) ===================

@davydov-d davydov-d merged commit a3c75e7 into master Jun 8, 2023
28 checks passed
@davydov-d davydov-d deleted the ddavydov/#24555-source-gitlab-fail-on-extra-columns branch June 8, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/gitlab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants