New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨🚨 Source Hubspot - fixed incremental for engagement stream #27161
Merged
midavadim
merged 27 commits into
master
from
midavadim/26365-hubspot-fix-incremental-sync
Jun 29, 2023
Merged
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2f9f689
fixed incremental for engagement stream
midavadim 3542f7f
added comments
midavadim 85815f7
updated docs
midavadim 4cb52b0
updated schema for email_events
midavadim 857f2c8
updated expected records and increased major connector version
midavadim 1db2e4c
added backward_compatibility_tests_config
midavadim 80a9b49
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 3284504
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim cb48802
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim eeac803
added email_event record with value in browser.version field
midavadim a398b44
Merge remote-tracking branch 'origin/midavadim/26365-hubspot-fix-incr…
midavadim 3b86d90
🤖 Auto format source-hubspot code [skip ci]
octavia-squidington-iii cb335c3
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 6ac4ffc
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 9c38682
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim b1c3ddf
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 798fed7
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 335c609
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 9338c20
Merge remote-tracking branch 'origin/midavadim/26365-hubspot-fix-incr…
midavadim b887d91
fixed expected records
midavadim 7ab2e20
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 575e1f5
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 7b10190
updated version if docker file
midavadim 072ada4
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 87f8431
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 8597d53
Merge branch 'master' into midavadim/26365-hubspot-fix-incremental-sync
midavadim 3f21afa
fix expected_records.jsonl
midavadim File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 9 additions & 1 deletion
10
airbyte-integrations/connectors/source-hubspot/integration_tests/expected_records.jsonl
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More pythonic way)
since_date_timestamp = stream_state.get(self.updated_at_field) if stream_state else stream_state
since_date = pendulum.from_timestamp(int(since_date_timestamp) / 1000) if since_date_timestamp else self._start_date