Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Source facebook-marketing: Pin FB marketing to 0.4.0 on Cloud #27164

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Jun 8, 2023

What

This PR seems to be preventing users from saving changes or retesting their existing Source

[This PR](#26941) seems to be preventing users from saving changes or retesting their existing Source
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@girarda girarda requested a review from pedroslopez June 8, 2023 17:35
@girarda girarda marked this pull request as ready for review June 8, 2023 17:35
@girarda girarda changed the title Pin FB marketing to 0.4.0 on Cloud 馃悰 source-facebook-marketing: Pin FB marketing to 0.4.0 on Cloud Jun 8, 2023
@girarda girarda enabled auto-merge (squash) June 8, 2023 17:37
@girarda girarda changed the title 馃悰 source-facebook-marketing: Pin FB marketing to 0.4.0 on Cloud 馃悰 Source facebook-marketing: Pin FB marketing to 0.4.0 on Cloud Jun 8, 2023
@girarda girarda merged commit 37244b1 into master Jun 8, 2023
22 of 29 checks passed
@girarda girarda deleted the alex/pin_fb_marketing branch June 8, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants