Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source google analytics data api: Improve error messages #27175

Merged

Conversation

artem1205
Copy link
Collaborator

What

Resolve #26274

How

refactor error messages

Recommended reading order

  1. y.python

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

…-v4-26274

# Conflicts:
#	airbyte-integrations/connectors/source-google-analytics-data-api/Dockerfile
#	airbyte-integrations/connectors/source-google-analytics-data-api/metadata.yaml
#	airbyte-integrations/connectors/source-google-analytics-data-api/source_google_analytics_data_api/source.py
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jun 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 8, 2023
@artem1205
Copy link
Collaborator Author

artem1205 commented Jun 8, 2023

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/5215786239
❌ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/5215786239
🐛 https://gradle.com/s/rxli25y66kgnw

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: A ...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
====== 1 failed, 38 passed, 2 skipped, 102 warnings in 1229.86s (0:20:29) ======

> Task :airbyte-integrations:connectors:source-google-analytics-data-api:connectorAcceptanceTest FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings
27 actionable tasks: 9 executed, 18 up-to-date

Publishing build scan...
https://gradle.com/s/rxli25y66kgnw

S3 cache writes: 1, elapsed: 606ms, sent to cache: 457 B

@artem1205
Copy link
Collaborator Author

artem1205 commented Jun 9, 2023

/test connector=connectors/source-google-analytics-data-api

🕑 connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/5220823554
✅ connectors/source-google-analytics-data-api https://github.com/airbytehq/airbyte/actions/runs/5220823554
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_analytics_data_api/__init__.py            2      0   100%
source_google_analytics_data_api/authenticator.py      44      2    95%
source_google_analytics_data_api/utils.py              42      2    95%
source_google_analytics_data_api/source.py            255     31    88%
source_google_analytics_data_api/api_quota.py          94     12    87%
-----------------------------------------------------------------------
TOTAL                                                 437     47    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
=========== 39 passed, 2 skipped, 102 warnings in 1282.60s (0:21:22) ===========

@artem1205 artem1205 self-assigned this Jun 9, 2023
@artem1205 artem1205 merged commit 797eb4f into master Jun 9, 2023
22 of 25 checks passed
@artem1205 artem1205 deleted the artem1205/source-google-analytics-data-api-v4-26274 branch June 9, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-data-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Google Analytics 4 source Error Messages
3 participants