🐛 Source Facebook Marketing: add `complete_oauth_server_output_specification` to spec #27201

arsenlosenko · 2023-06-09T11:40:20Z

What

Resolving this OC issue:
https://github.com/airbytehq/oncall/issues/2239
After changes made previously here, some users were not able to use connector properly due to missing entry in advanced_auth declaration.

How

Update advanced_auth declaration in spec and add complete_oauth_server_output_specification entry.

…tion to spec

arsenlosenko · 2023-06-09T11:40:29Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5221471352
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5221471352
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             26      0   100%
source_facebook_marketing/streams/common.py                    44      0   100%
source_facebook_marketing/streams/async_job.py                217      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              39      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/streams/patches.py                   22      2    91%
source_facebook_marketing/source.py                            62      6    90%
source_facebook_marketing/api.py                               99     10    90%
source_facebook_marketing/streams/base_insight_streams.py     145     16    89%
source_facebook_marketing/streams/base_streams.py             143     22    85%
source_facebook_marketing/streams/streams.py                  160     29    82%
-------------------------------------------------------------------------------
TOTAL                                                        1042     88    92%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              39      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/api.py                               99     13    87%
source_facebook_marketing/streams/patches.py                   22      3    86%
source_facebook_marketing/streams/base_streams.py             143     28    80%
source_facebook_marketing/streams/streams.py                  160     50    69%
source_facebook_marketing/streams/common.py                    44     16    64%
source_facebook_marketing/utils.py                             26     10    62%
source_facebook_marketing/source.py                            62     24    61%
source_facebook_marketing/streams/base_insight_streams.py     145     64    56%
source_facebook_marketing/streams/async_job.py                217    136    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                        1042    404    61%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 39 passed, 2 skipped in 4865.27s (1:21:05) ==================

github-actions · 2023-06-09T11:40:42Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

arsenlosenko · 2023-06-12T11:29:11Z

/publish connector=connectors/source-facebook-marketing pre-release=true run-tests=false

⚠️ The publish slash command is now deprecated.

The connector publication happens on merge to the master branch.

Please use /legacy-publish if you need to publish normalization images.

Please join the #publish-on-merge-updates slack channel to track ongoing publish pipelines.

Please reach out to the @dev-connector-ops team if you need support in publishing a connector.

arsenlosenko · 2023-06-12T11:44:28Z

/legacy-publish connector=connectors/source-facebook-marketing pre-release=true run-tests=false

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/5243115298

Connector	Version	Did it publish?
connectors/source-facebook-marketing	0.4.2-dev.1f417abe	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

bnchrch · 2023-06-14T15:43:34Z

@arsenlosenko It looks like source_facebook_marketing/source.py needs to be run through the formatter.

Let me know if you need a hand with that :)

arsenlosenko · 2023-06-14T15:45:23Z

@bnchrch good point, I'll run this file through formatter once again before merging this, thanks👍

…g-fix-advanced-auth

octavia-squidington-iii · 2023-06-14T20:11:02Z

source-facebook-marketing test report (commit `7a71a0cad6`) - ❌

⏲️ Total pipeline duration: 4827 seconds

Step	Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check.	✅
Connector version increment check.	✅
QA checks	✅
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

alafanechere · 2023-06-15T07:48:59Z

@arsenlosenko please do not use /legacy-publish to publish pre-release connector as the build logic is different now. What you publish with /legacy-test might not match what eventually gets published.
Please use this workflow on your branch.

arsenlosenko · 2023-06-15T07:50:56Z

@alafanechere understood, thanks for pointing that out

octavia-squidington-iii · 2023-06-15T08:41:31Z

source-facebook-marketing test report (commit `3ceb09dc09`) - ✅

⏲️ Total pipeline duration: 3451 seconds

Step	Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check.	✅
Connector version increment check.	✅
QA checks	✅
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

Source Facebook Marketing: add complete_oauth_server_output_specifica…

24f5144

…tion to spec

arsenlosenko self-assigned this Jun 9, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Jun 9, 2023

arsenlosenko changed the title ~~Source Facebook Marketing: add complete_oauth_server_output_specification to spec~~ 🐛 Source Facebook Marketing: add complete_oauth_server_output_specification to spec Jun 9, 2023

Update changelog

1f417ab

arsenlosenko requested review from pedroslopez and lazebnyi June 13, 2023 07:56

lazebnyi approved these changes Jun 13, 2023

View reviewed changes

girarda approved these changes Jun 13, 2023

View reviewed changes

Merge branch 'master' into arsenlosenko/2239-source-facebook-marketin…

7a71a0c

…g-fix-advanced-auth

Unpinned previous version for cloud, ran blackFormat

3ceb09d

arsenlosenko merged commit 53c5229 into master Jun 15, 2023
23 checks passed

arsenlosenko deleted the arsenlosenko/2239-source-facebook-marketing-fix-advanced-auth branch June 15, 2023 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Facebook Marketing: add `complete_oauth_server_output_specification` to spec #27201

🐛 Source Facebook Marketing: add `complete_oauth_server_output_specification` to spec #27201

arsenlosenko commented Jun 9, 2023

arsenlosenko commented Jun 9, 2023 •

edited by github-actions bot

github-actions bot commented Jun 9, 2023 •

edited by arsenlosenko

arsenlosenko commented Jun 12, 2023 •

edited by github-actions bot

arsenlosenko commented Jun 12, 2023 •

edited by github-actions bot

bnchrch commented Jun 14, 2023

arsenlosenko commented Jun 14, 2023

octavia-squidington-iii commented Jun 14, 2023

alafanechere commented Jun 15, 2023

arsenlosenko commented Jun 15, 2023

octavia-squidington-iii commented Jun 15, 2023

🐛 Source Facebook Marketing: add complete_oauth_server_output_specification to spec #27201

🐛 Source Facebook Marketing: add complete_oauth_server_output_specification to spec #27201

Conversation

arsenlosenko commented Jun 9, 2023

What

How

arsenlosenko commented Jun 9, 2023 • edited by github-actions bot

Build Passed

github-actions bot commented Jun 9, 2023 • edited by arsenlosenko

Before Merging a Connector Pull Request

arsenlosenko commented Jun 12, 2023 • edited by github-actions bot

arsenlosenko commented Jun 12, 2023 • edited by github-actions bot

bnchrch commented Jun 14, 2023

arsenlosenko commented Jun 14, 2023

octavia-squidington-iii commented Jun 14, 2023

source-facebook-marketing test report (commit 7a71a0cad6) - ❌

alafanechere commented Jun 15, 2023

arsenlosenko commented Jun 15, 2023

octavia-squidington-iii commented Jun 15, 2023

source-facebook-marketing test report (commit 3ceb09dc09) - ✅

🐛 Source Facebook Marketing: add `complete_oauth_server_output_specification` to spec #27201

🐛 Source Facebook Marketing: add `complete_oauth_server_output_specification` to spec #27201

arsenlosenko commented Jun 9, 2023 •

edited by github-actions bot

github-actions bot commented Jun 9, 2023 •

edited by arsenlosenko

arsenlosenko commented Jun 12, 2023 •

edited by github-actions bot

arsenlosenko commented Jun 12, 2023 •

edited by github-actions bot

source-facebook-marketing test report (commit `7a71a0cad6`) - ❌

source-facebook-marketing test report (commit `3ceb09dc09`) - ✅