Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Twilio: New streams UserConversations with parent Users #27221

Merged
merged 18 commits into from Jul 13, 2023
Merged

✨Source Twilio: New streams UserConversations with parent Users #27221

merged 18 commits into from Jul 13, 2023

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Jun 9, 2023 •
edited

What

Closes #26938

Enhancement

New streams:

  • Users
  • UserConversations

Recommended reading order

  1. source_twilio/source.py
  2. source_twilio/streams.py
  3. source_twilio/schemas/*

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter [Yes]

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Documentation which references the generator is updated as needed

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023 •
edited by archangelic

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@btkcodedev btkcodedev changed the title 🎉Source Twilio: New streams UserConversations with parent Users ✨Source Twilio: New streams UserConversations with parent Users Jun 9, 2023
@jrolom jrolom added the contributor-program PRs submitted through the contributor program. label Jun 9, 2023
@marcosmarxm
Copy link
Member

@archangelic what is the status of this PR?

@archangelic
Copy link
Contributor

I fixed some merge conflicts. Running tests now to see if we can get this merged asap. I will update soon.

@darynaishchenko darynaishchenko self-assigned this Jul 6, 2023
@darynaishchenko darynaishchenko mentioned this pull request Jul 10, 2023
Closed
@darynaishchenko
Copy link
Collaborator

@btkcodedev The acceptance tests has started to fail, could you check it please.

@darynaishchenko darynaishchenko merged commit c6c3ee1 into airbytehq:master Jul 13, 2023
39 of 43 checks passed
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@btkcodedev @archangelic
@darynaishchenko @efimmatytsin
✨Source Twilio: New streams UserConversations with parent Users (airb…
334a963 
…ytehq#27221)

* New stream UserConversations with parent Users

* Update Docs

* EOF streams.py

* formatting fixes

* Add account_sid as primary key

* bump version

* fix merge errors

* fix catalog and expected records

---------

Co-authored-by: Mal Hancock <mallory@archangelic.space>
Co-authored-by: Daryna Ishchenko <darina.ishchenko17@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archangelic archangelic archangelic approved these changes

@darynaishchenko darynaishchenko darynaishchenko approved these changes

Assignees

@darynaishchenko darynaishchenko

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run community connectors/source/twilio contributor-program PRs submitted through the contributor program. gl gl-review team/connectors-python
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Twilio : new stream user converstaions
7 participants
@btkcodedev @marcosmarxm @archangelic @darynaishchenko @octavia-squidington-iii @bmcgilli @jrolom