Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Stripe: Add new Streams #27362

Merged
merged 41 commits into from Jun 19, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Jun 14, 2023

What

Resolve

How

Add new Streams:

  • Transactions
  • Transfer Reversals
  • Setup Attempts
  • Usage Records

Fix schemas:

  • invoice items

Recommended reading order

  1. y.python

🚨 User Impact 🚨

schemas changes => schema refresh will be needed;
affect only customer from https://github.com/airbytehq/oncall/issues/1996

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

# Conflicts:
#	airbyte-integrations/connectors/source-stripe/integration_tests/expected_records.jsonl
# Conflicts:
#	airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml
#	airbyte-integrations/connectors/source-stripe/integration_tests/configured_catalog.json
#	airbyte-integrations/connectors/source-stripe/source_stripe/schemas/payment_intents.json
#	airbyte-integrations/connectors/source-stripe/source_stripe/schemas/payment_methods.json
#	airbyte-integrations/connectors/source-stripe/source_stripe/source.py
#	airbyte-integrations/connectors/source-stripe/source_stripe/streams.py
@artem1205 artem1205 self-assigned this Jun 14, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 14, 2023
@artem1205 artem1205 marked this pull request as draft June 14, 2023 22:26
@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 8f62a4f349) - ❌

⏲️ Total pipeline duration: 570 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 8f62a4f349) - ❌

⏲️ Total pipeline duration: 484 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 03bd02e468) - ✅

⏲️ Total pipeline duration: 467 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

# Conflicts:
#	airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml
#	airbyte-integrations/connectors/source-stripe/integration_tests/abnormal_state.json
#	airbyte-integrations/connectors/source-stripe/integration_tests/configured_catalog.json
#	airbyte-integrations/connectors/source-stripe/integration_tests/expected_records.jsonl
#	airbyte-integrations/connectors/source-stripe/source_stripe/source.py
#	airbyte-integrations/connectors/source-stripe/source_stripe/streams.py
#	airbyte-integrations/connectors/source-stripe/unit_tests/test_source.py
#	docs/integrations/sources/stripe.md
@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 1d6ec50d9c) - ❌

⏲️ Total pipeline duration: 38 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 30c903a27c) - ✅

⏲️ Total pipeline duration: 503 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@artem1205 artem1205 requested a review from a team June 19, 2023 15:51
@artem1205 artem1205 merged commit 3df8196 into master Jun 19, 2023
23 of 24 checks passed
@artem1205 artem1205 deleted the artem1205/source-stripe-usage-records-16982 branch June 19, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
None yet
5 participants