New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Facebook marketing: reduce start date by one day #27483
🐛 Source Facebook marketing: reduce start date by one day #27483
Conversation
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ❌ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
…of github.com:airbytehq/airbyte into ddavydov/#1975-source-fb-reduce-start-date-by-one-day
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ❌ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Outdated
Show resolved
Hide resolved
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ❌ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
What
https://github.com/airbytehq/oncall/issues/1975
How
According to the logs, the requested date isn't actually older than 37 months. But the exception says it is. The only reasonable explanation to me of what's going on is possible timezone difference causing the start date be out of 37 months bound. I think we need to increase the start date by one day in order to stay within the appropriate date-time boundaries.
🚨 User Impact 🚨