Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Facebook marketing: reduce start date by one day #27483

Merged

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Jun 19, 2023

What

https://github.com/airbytehq/oncall/issues/1975

How

According to the logs, the requested date isn't actually older than 37 months. But the exception says it is. The only reasonable explanation to me of what's going on is possible timezone difference causing the start date be out of 37 months bound. I think we need to increase the start date by one day in order to stay within the appropriate date-time boundaries.

🚨 User Impact 🚨

  • Less data (max. difference - one day) may be replicated in case the start date in user's config is set to more then 37 months ago

@davydov-d davydov-d requested a review from lazebnyi June 19, 2023 19:12
@octavia-squidington-iii
Copy link
Collaborator

source-facebook-marketing test report (commit efbff4d9dd) - ❌

⏲️ Total pipeline duration: 4029 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…of github.com:airbytehq/airbyte into ddavydov/#1975-source-fb-reduce-start-date-by-one-day
@octavia-squidington-iii
Copy link
Collaborator

source-facebook-marketing test report (commit f830738807) - ❌

⏲️ Total pipeline duration: 3802 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-facebook-marketing test report (commit 77d6d62e3e) - ✅

⏲️ Total pipeline duration: 3958 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@davydov-d davydov-d enabled auto-merge (squash) June 21, 2023 06:39
@davydov-d davydov-d disabled auto-merge June 21, 2023 06:48
@davydov-d davydov-d closed this Jun 21, 2023
@davydov-d davydov-d reopened this Jun 21, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-facebook-marketing test report (commit 9d00b0fc8b) - ❌

⏲️ Total pipeline duration: 3628 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-facebook-marketing test report (commit 6c7688a673) - ✅

⏲️ Total pipeline duration: 3162 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-facebook-marketing test report (commit 3f1477d9a9) - ❌

⏲️ Total pipeline duration: 3359 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-facebook-marketing test report (commit 0e0add5f2f) - ❌

⏲️ Total pipeline duration: 3968 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-facebook-marketing test report (commit d86437bafb) - ✅

⏲️ Total pipeline duration: 3780 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@davydov-d davydov-d merged commit 076065c into master Jun 21, 2023
22 checks passed
@davydov-d davydov-d deleted the ddavydov/#1975-source-fb-reduce-start-date-by-one-day branch June 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants