Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Recharge: migrated to 2021-11 api version #27503

Merged
merged 10 commits into from
Jun 26, 2023

Conversation

darynaishchenko
Copy link
Collaborator

What

resolved: https://github.com/airbytehq/oncall/issues/2060
Due to changed in api version and incorrect pagination stream subscription read not all records

How

Changed next_page_token: added cursor field, migrated to new api version 2021-11

@darynaishchenko darynaishchenko self-assigned this Jun 20, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/recharge labels Jun 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@darynaishchenko darynaishchenko changed the title Source Recharge: migrated to 2021-11 api version 🐛 Source Recharge: migrated to 2021-11 api version Jun 20, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit 55c5caab88) - ❌

⏲️ Total pipeline duration: 4351 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit fc84b43837) - ❌

⏲️ Total pipeline duration: 4331 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit 94a38cdc39) - ❌

⏲️ Total pipeline duration: 6746 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit a497398a6a) - ❌

⏲️ Total pipeline duration: 14537 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit cc6ef09080) - ✅

⏲️ Total pipeline duration: 458 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@darynaishchenko
Copy link
Collaborator Author

@davydov-d I can't leave stream slicing as it was, because it produces to duplicates. In stream with 2 records we receive 6. For pagination I'm using next_page_token. As I understand it's no way to retrieve cursor in stream_slices method. Only if we add cursor inside the record, but I don't think it's good idea.

@darynaishchenko darynaishchenko force-pushed the daryna/source-recharge/oc206-missing-records branch from f48acd3 to 89e3baa Compare June 26, 2023 10:57
@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit f48acd3caf) - ✅

⏲️ Total pipeline duration: 421 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit 89e3baa968) - ✅

⏲️ Total pipeline duration: 364 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@darynaishchenko darynaishchenko merged commit c71b8f8 into master Jun 26, 2023
23 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-recharge/oc206-missing-records branch June 26, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/recharge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants