Source Salesloft: Added new streams (call data records, call dispositions, call sentiments, custom fields, meetings, searches) #27505

markortleb-dice · 2023-06-20T14:33:07Z

What

This pull request will add the following streams to the Salesloft Source. This is the issue this work is related to: #27504.

Here are the new streams:

Call Data Records
Call Dispositions
Call Sentiments
Custom Fields
Meetings
Searches

How

These new Salesloft Source streams were added in the line with the same pattern that all previous Salesloft Source streams
have. The only stream that was a bit different was Searches, which has a POST request rather than GET (which all other
Salesloft Source streams have).

🚨 User Impact 🚨

There are no breaking changes in this 1.2.0 release. In this change, we are only adding net-new Salesloft Source streams.
We made no modifications to existing streams.

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

…ms-1--markortleb-dice adding new Salesloft streams

…ms-1--markortleb-dice change the version to 1.1.1

CLAassistant · 2023-06-20T14:33:18Z

All committers have signed the CLA.

github-actions · 2023-06-20T14:33:29Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
The connector tests are passing in CI
You've updated the connector's metadata.yaml file (new!)
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

sajarin

Thanks for the PR! Left some comments:

airbyte-integrations/connectors/source-salesloft/Dockerfile

airbyte-integrations/connectors/source-salesloft/metadata.yaml

...yte-integrations/connectors/source-salesloft/source_salesloft/schemas/call_data_records.json

...yte-integrations/connectors/source-salesloft/source_salesloft/schemas/call_dispositions.json

airbyte-integrations/connectors/source-salesloft/source_salesloft/schemas/call_sentiments.json

airbyte-integrations/connectors/source-salesloft/source_salesloft/schemas/custom_fields.json

airbyte-integrations/connectors/source-salesloft/source_salesloft/schemas/meetings.json

airbyte-integrations/connectors/source-salesloft/source_salesloft/schemas/searches.json

docs/integrations/sources/salesloft.md

sajarin

A couple of more formatting things:

Run the ./gradlew --no-daemon :airbyte-integrations:connectors:source-salesloft:airbytePythonFormat command to format the files and commit them

Bump the number of streams in the test_streams file (expected streams should be 29 now instead of 23)

airbyte-integrations/connectors/source-salesloft/metadata.yaml

markortleb-dice · 2023-06-29T19:34:32Z

A couple of more formatting things:

Run the ./gradlew --no-daemon :airbyte-integrations:connectors:source-salesloft:airbytePythonFormat command to format the files and commit them

Bump the number of streams in the test_streams file (expected streams should be 29 now instead of 23)

Thank you for the feedback @sajarin . As requested, I was able to run that Gradle command which automatically formatted the Salesloft files, and I also changed the expected number of streams from 23 to 29.

marcosmarxm · 2023-06-30T14:40:49Z

@markortleb-dice you must sign the CLA.

markortleb-dice · 2023-06-30T15:29:06Z

@markortleb-dice you must sign the CLA.

CLA is now signed!

marcosmarxm

There are some fixes need to be made in this contribution @markortleb-dice.

airbyte-integrations/connectors/source-salesloft/source_salesloft/source.py

…om Fields to full refresh. Use created_at instead of updated_at for timestamp field for Meetings.

… there is no viable cursor field option.

markortleb-dice · 2023-07-10T14:00:27Z

There are some fixes need to be made in this contribution @markortleb-dice.

Thank you for the feedback @marcosmarxm . I have made the changes as requested:

Call Dispositions, Call Sentiments, and Custom Fields streams have been converted to non-incremental streams.
The created_at_field was changed to created_at rather than updated_at for the Meetings stream. I also converted the Meetings stream to non-incremental, since it does not seem to have a good field to use as a cursor when requesting from the API, such as updated_at. Here is a link to the docs for Meetings just fyi: https://developers.salesloft.com/docs/api/meetings-index.

Stale review

…ions, call sentiments, custom fields, meetings, searches) (airbytehq#27505) * adding new Salesloft streams * change the version to 1.1.1 * increment the patch version * fixing typo in meetings * fix another typo * making corrections requested by reviewer * increment version in salesloft metadata to 1.2.0 * reformating files * fix expected records * Source Salesloft: change Call Dispositions, Call Sentiments, and Custom Fields to full refresh. Use created_at instead of updated_at for timestamp field for Meetings. * changing meetings cursor field to created_at * Source Salesloft: Convert meetings to a non-incremental stream, since there is no viable cursor field option. * fix schemas and update tests --------- Co-authored-by: sh4sh <6833405+sh4sh@users.noreply.github.com> Co-authored-by: Mal Hancock <mallory@archangelic.space>

markortleb-dice and others added 4 commits June 14, 2023 10:25

adding new Salesloft streams

36d3fe3

Merge pull request #1 from markortleb-dice/source-salesloft-new-strea…

a8e799e

…ms-1--markortleb-dice adding new Salesloft streams

change the version to 1.1.1

fc07fe3

Merge pull request #2 from markortleb-dice/source-salesloft-new-strea…

bcd16ea

…ms-1--markortleb-dice change the version to 1.1.1

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/salesloft labels Jun 20, 2023

markortleb-dice and others added 7 commits June 20, 2023 10:58

Merge branch 'master' into master

e437287

increment the patch version

0b473d1

Merge branch 'master' into master

64922d0

Merge branch 'master' into master

68443d3

fixing typo in meetings

62c5553

fix another typo

38d19b2

Merge branch 'master' into master

8a6ee8a

sajarin suggested changes Jun 27, 2023

View reviewed changes

marcosmarxm added the team/tse Technical Support Engineers label Jun 27, 2023

markortleb-dice and others added 3 commits June 27, 2023 13:42

making corrections requested by reviewer

35ea7dc

Merge branch 'master' of https://github.com/markortleb-dice/airbyte

1a884d5

Merge branch 'master' into master

3acd289

markortleb-dice requested a review from sajarin June 27, 2023 22:17

sajarin previously requested changes Jun 29, 2023

View reviewed changes

airbyte-integrations/connectors/source-salesloft/metadata.yaml Show resolved Hide resolved

markortleb-dice and others added 3 commits June 29, 2023 11:44

Merge branch 'master' into master

29a6490

increment version in salesloft metadata to 1.2.0

15b4a64

reformating files

6c2082e

markortleb-dice requested a review from sajarin June 29, 2023 19:32

markortleb-dice and others added 4 commits June 30, 2023 11:33

Merge branch 'master' into master

0eb6199

Merge branch 'master' into master

5b6599c

Merge branch 'master' into master

f9105ab

Merge branch 'master' into master

52184f3

sh4sh mentioned this pull request Jul 5, 2023

CI checks for #27505 #27987

Closed

markortleb-dice and others added 3 commits July 6, 2023 11:08

Merge branch 'master' into master

5e172b7

fix expected records

49f7154

Merge branch 'master' into master

5b58b0e

marcosmarxm previously requested changes Jul 7, 2023

View reviewed changes

markortleb-dice added 3 commits July 7, 2023 12:14

Source Salesloft: change Call Dispositions, Call Sentiments, and Cust…

9b88657

…om Fields to full refresh. Use created_at instead of updated_at for timestamp field for Meetings.

changing meetings cursor field to created_at

9054443

Source Salesloft: Convert meetings to a non-incremental stream, since…

70a6562

… there is no viable cursor field option.

markortleb-dice requested a review from marcosmarxm July 10, 2023 14:00

fix schemas and update tests

084b365

archangelic approved these changes Jul 11, 2023

View reviewed changes

archangelic merged commit 8ff7e58 into airbytehq:master Jul 11, 2023
38 of 41 checks passed

marcosmarxm mentioned this pull request Sep 15, 2023

Source Salesloft: Add new streams (call data records, call dispositions, call sentiments, custom fields, meetings, searches) #27504

Closed

1 task

topefolorunso mentioned this pull request Oct 3, 2023

Source Salesloft: new stream Meetings #21386

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Salesloft: Added new streams (call data records, call dispositions, call sentiments, custom fields, meetings, searches) #27505

Source Salesloft: Added new streams (call data records, call dispositions, call sentiments, custom fields, meetings, searches) #27505

markortleb-dice commented Jun 20, 2023 •

edited

CLAassistant commented Jun 20, 2023 •

edited

github-actions bot commented Jun 20, 2023 •

edited by sh4sh

sajarin left a comment

sajarin left a comment

markortleb-dice commented Jun 29, 2023

marcosmarxm commented Jun 30, 2023

markortleb-dice commented Jun 30, 2023

marcosmarxm left a comment

markortleb-dice commented Jul 10, 2023

Source Salesloft: Added new streams (call data records, call dispositions, call sentiments, custom fields, meetings, searches) #27505

Source Salesloft: Added new streams (call data records, call dispositions, call sentiments, custom fields, meetings, searches) #27505

Conversation

markortleb-dice commented Jun 20, 2023 • edited

What

How

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

CLAassistant commented Jun 20, 2023 • edited

github-actions bot commented Jun 20, 2023 • edited by sh4sh

Before Merging a Connector Pull Request

sajarin left a comment

Choose a reason for hiding this comment

sajarin left a comment

Choose a reason for hiding this comment

markortleb-dice commented Jun 29, 2023

marcosmarxm commented Jun 30, 2023

markortleb-dice commented Jun 30, 2023

marcosmarxm left a comment

Choose a reason for hiding this comment

markortleb-dice commented Jul 10, 2023

markortleb-dice commented Jun 20, 2023 •

edited

CLAassistant commented Jun 20, 2023 •

edited

github-actions bot commented Jun 20, 2023 •

edited by sh4sh