Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Stripe: Fix formatting #27522

Merged
merged 6 commits into from Jun 21, 2023

Conversation

artem1205
Copy link
Collaborator

What

Fix Source Stripe Connector health report

How

Fix formatting

Recommended reading order

  1. expected_records.jsonl

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 marked this pull request as ready for review June 20, 2023 18:34
@artem1205 artem1205 closed this Jun 20, 2023
@artem1205 artem1205 reopened this Jun 20, 2023
@artem1205 artem1205 requested a review from davydov-d June 20, 2023 20:27
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 20, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit a477e769f5) - ❌

⏲️ Total pipeline duration: 508 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 76785119e6) - ❌

⏲️ Total pipeline duration: 526 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 2b018af7a1) - ✅

⏲️ Total pipeline duration: 518 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@artem1205 artem1205 enabled auto-merge (squash) June 21, 2023 10:55
@artem1205 artem1205 disabled auto-merge June 21, 2023 10:55
@artem1205 artem1205 closed this Jun 21, 2023
@artem1205 artem1205 reopened this Jun 21, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit c49d31b9f5) - ✅

⏲️ Total pipeline duration: 518 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@artem1205 artem1205 merged commit aaf8f34 into master Jun 21, 2023
22 checks passed
@artem1205 artem1205 deleted the artem1205/connector-health-fix-stripe-google branch June 21, 2023 12:16
@artem1205 artem1205 self-assigned this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants