Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors-ci: better connector test debugging experience (1/2) #27550

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jun 21, 2023

What

#27497
We want to better share connector test results with connector developer.
I made the test report generate an HTML page that we upload to our airbyte-ci-reports public bucket.
The link to the reports are shared in the test summary commented on the PR.
We'll make them available on nightly build daily report in a second PR.

How

  • Create a jinja template for reports
  • Redact secrets from stdout or stderr to get the same level of secret masking we have in GHA
  • Upload html reports to GCS when running in the CI, otherwise open the local HTML file in the default web browser.

@octavia-squidington-iii
Copy link
Collaborator

source-openweather test report (commit 91815e0fa4) - ❌

⏲️ Total pipeline duration: 93 seconds

Step Result
Validate airbyte-integrations/connectors/source-openweather/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-openweather docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-openweather test

@alafanechere alafanechere force-pushed the augustin/connectors-ci/better-logging-ux branch from 91815e0 to 7457733 Compare June 21, 2023 16:32
@alafanechere alafanechere force-pushed the augustin/connectors-ci/better-logging-ux branch from 7457733 to d8214e9 Compare June 21, 2023 16:33
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Jun 21, 2023
@alafanechere alafanechere force-pushed the augustin/connectors-ci/better-logging-ux branch from 9244f5b to f62c869 Compare June 21, 2023 16:35
@alafanechere alafanechere changed the title connectors-ci: better logging ux connectors-ci: better connector test debugging experience (1/2) Jun 21, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-pokeapi test report (commit 8ddc9e4897) - ❌

⏲️ Total pipeline duration: 102 seconds

Step Result
Validate airbyte-integrations/connectors/source-pokeapi/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-pokeapi docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-pokeapi test

@alafanechere alafanechere requested a review from a team June 21, 2023 17:06
@alafanechere alafanechere force-pushed the augustin/connectors-ci/better-logging-ux branch from 8ddc9e4 to f62c869 Compare June 21, 2023 17:08
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Jun 21, 2023
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those HTML reports are :chef-kiss-emoji:!

In a later PR we will see:

  • cloudflare auth + sub domain
  • links for nightly tests

@alafanechere alafanechere enabled auto-merge (squash) June 21, 2023 17:14
@alafanechere alafanechere merged commit e742f8d into master Jun 21, 2023
19 checks passed
@alafanechere alafanechere deleted the augustin/connectors-ci/better-logging-ux branch June 21, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants