Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 🚨 Source Recharge: fix stream schema #27612

Merged
merged 61 commits into from Jul 11, 2023

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1879

How

Change date type of the shopify_variant_id_not_found field in the Charges stream from integer to string

🚨 User Impact 🚨

This is a potentially breaking change because the data type is changed

@davydov-d davydov-d closed this Jun 23, 2023
@davydov-d davydov-d reopened this Jun 23, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit d82bae5022) - ✅

⏲️ Total pipeline duration: 451 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit 33a5045a06) - ✅

⏲️ Total pipeline duration: 1192 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@bnchrch
Copy link
Contributor

bnchrch commented Jun 23, 2023

@davydov-d Would you mind linking the breaking change doc?

@davydov-d davydov-d requested a review from a team June 26, 2023 09:19
@davydov-d davydov-d added the breaking-change Don't merge me unless you are ready. label Jun 26, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 26, 2023

@bnchrch
Copy link
Contributor

bnchrch commented Jun 26, 2023

No worries! Also @davydov-d I need access (ben@airbyte.io)

@davydov-d
Copy link
Collaborator Author

@bnchrch done!

Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davydov-d

Everything looks great.

Ill leave it to you to merge when TCS has a release date and its passed

@jnr0790
Copy link
Contributor

jnr0790 commented Jun 26, 2023

@davydov-d let's schedule this for July 11th at 4 pm UTC. I'll get comms sent to the users today.

@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit dfc6f9daad) - ❌

⏲️ Total pipeline duration: 347 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@octavia-squidington-iii
Copy link
Collaborator

source-recharge test report (commit 198c0551b2) - ✅

⏲️ Total pipeline duration: 331 seconds

Step Result
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-recharge docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-recharge test

@jnr0790
Copy link
Contributor

jnr0790 commented Jul 11, 2023

Just a reminder to get this out at 4 pm UTC today

@davydov-d davydov-d merged commit 0e11a6f into master Jul 11, 2023
22 checks passed
@davydov-d davydov-d deleted the ddavydov/#1879-source-recharge-fix-schema branch July 11, 2023 16:00
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* airbytehq#1879 source recharge: fix schema

* airbytehq#1879 source recharge: upd changelog

* upd CAT config

* source recharge: upd CAT config

---------

Co-authored-by: Augustin <augustin@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation breaking-change Don't merge me unless you are ready. checklist-action-run connectors/source/recharge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants