New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨 🚨 Source Recharge: fix stream schema #27612
Conversation
source-recharge test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-recharge docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-recharge test
source-recharge test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-recharge docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-recharge test
@davydov-d Would you mind linking the breaking change doc? |
@bnchrch yep, sorry for the delay |
No worries! Also @davydov-d I need access (ben@airbyte.io) |
@bnchrch done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davydov-d
Everything looks great.
Ill leave it to you to merge when TCS has a release date and its passed
@davydov-d let's schedule this for July 11th at 4 pm UTC. I'll get comms sent to the users today. |
…m:airbytehq/airbyte into ddavydov/#1879-source-recharge-fix-schema
source-recharge test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-recharge docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-recharge test
source-recharge test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-recharge/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-recharge docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-recharge test
Just a reminder to get this out at 4 pm UTC today |
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds * airbytehq#1879 source recharge: fix schema * airbytehq#1879 source recharge: upd changelog * upd CAT config * source recharge: upd CAT config --------- Co-authored-by: Augustin <augustin@airbyte.io>
What
https://github.com/airbytehq/oncall/issues/1879
How
Change date type of the
shopify_variant_id_not_found
field in theCharges
stream frominteger
tostring
🚨 User Impact 🚨
This is a potentially breaking change because the data type is changed