Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Bing Ads: retry DNS failure #27619

Merged
merged 52 commits into from Jun 23, 2023

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/2209

How

Retry DNS failure

🚨 User Impact 🚨

No impact

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d davydov-d marked this pull request as ready for review June 22, 2023 18:30
@octavia-squidington-iii
Copy link
Collaborator

source-bing-ads test report (commit 701412e15e) - ❌

⏲️ Total pipeline duration: 56 seconds

Step Result
Validate airbyte-integrations/connectors/source-bing-ads/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-bing-ads docker image for platform linux/x86_64

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-bing-ads test report (commit 3cf08812c6) - ❌

⏲️ Total pipeline duration: 35 seconds

Step Result
Validate airbyte-integrations/connectors/source-bing-ads/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-bing-ads docker image for platform linux/x86_64

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

@alafanechere
Copy link
Contributor

@davydov-d FYI the link to logs is not working because of a special character in your branch name ...
The build step is failing because it's calling the spec command.
The spec command is broken on this connector:
TypeError: unsupported operand type(s) for |: 'type' and 'type'

@davydov-d
Copy link
Collaborator Author

@davydov-d FYI the link to logs is not working because of a special character in your branch name ... The build step is failing because it's calling the spec command. The spec command is broken on this connector: TypeError: unsupported operand type(s) for |: 'type' and 'type'

thanks @alafanechere! is there a way to handle those special characters in branch names?

@octavia-squidington-iii
Copy link
Collaborator

source-bing-ads test report (commit 948544ab41) - ✅

⏲️ Total pipeline duration: 662 seconds

Step Result
Validate airbyte-integrations/connectors/source-bing-ads/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-bing-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

@davydov-d davydov-d merged commit a6dd682 into master Jun 23, 2023
23 of 25 checks passed
@davydov-d davydov-d deleted the ddavydov/#2209-source-bing-ads-retry-dns-failure branch June 23, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/bing-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants