Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Typeform: add form_id field to records of responses stream #27653

Merged

Conversation

arsenlosenko
Copy link
Contributor

What

Resolving issue described here:
#21344
User requested to have ability to map records from responses stream to records from forms stream.

How

Added form_id from stream slice that we have and added it to list of records that we receive from responses endpoint. Also updated expected records with form_id values to match the changed structure of records.

@arsenlosenko arsenlosenko self-assigned this Jun 23, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/typeform labels Jun 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@arsenlosenko arsenlosenko marked this pull request as ready for review June 23, 2023 12:22
@octavia-squidington-iii
Copy link
Collaborator

source-typeform test report (commit f0df7acc43) - ❌

⏲️ Total pipeline duration: 180 seconds

Step Result
Validate airbyte-integrations/connectors/source-typeform/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-typeform docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-typeform test

@octavia-squidington-iii
Copy link
Collaborator

source-typeform test report (commit f0df7acc43) - ❌

⏲️ Total pipeline duration: 199 seconds

Step Result
Validate airbyte-integrations/connectors/source-typeform/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-typeform docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-typeform test

@octavia-squidington-iii
Copy link
Collaborator

source-typeform test report (commit 5c3925635d) - ✅

⏲️ Total pipeline duration: 157 seconds

Step Result
Validate airbyte-integrations/connectors/source-typeform/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-typeform docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-typeform test

@arsenlosenko arsenlosenko linked an issue Jun 23, 2023 that may be closed by this pull request
@octavia-squidington-iii
Copy link
Collaborator

source-typeform test report (commit 6e500c1786) - ❌

⏲️ Total pipeline duration: 172 seconds

Step Result
Validate airbyte-integrations/connectors/source-typeform/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-typeform docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-typeform test

@octavia-squidington-iii
Copy link
Collaborator

source-typeform test report (commit 87a2f96353) - ✅

⏲️ Total pipeline duration: 165 seconds

Step Result
Validate airbyte-integrations/connectors/source-typeform/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-typeform docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-typeform test

@arsenlosenko arsenlosenko merged commit 9f2659d into master Jun 26, 2023
22 checks passed
@arsenlosenko arsenlosenko deleted the arsenlosenko/21344-source-typeform-add-form-id-to-response branch June 26, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/typeform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Typeform: Associate Typeform Response with Form
4 participants