Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Hubspot: use fully qualified name for custom objects #27658

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Jun 23, 2023

What

https://github.com/airbytehq/oncall/issues/2294

How

  • Access custom objects via fully qualified name
  • Do not make extra api call to retrieve properties for custom object streams

🚨 User Impact 🚨

No impact

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @brianjlai. Once the test has been successfully completed, I will give my approval to the PR.

@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit 3aabb00e42) - ❌

⏲️ Total pipeline duration: 10mn45s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@davydov-d davydov-d closed this Jun 30, 2023
@davydov-d davydov-d reopened this Jun 30, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit 3aabb00e42) - ❌

⏲️ Total pipeline duration: 16.50s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit e0041d4c54) - ❌

⏲️ Total pipeline duration: 16.07s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

…for-custom-objects' of github.com:airbytehq/airbyte into ddavydov/#2294-source-hubspot-use-fully-qualified-name-for-custom-objects
@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit 08095001e7) - ❌

⏲️ Total pipeline duration: 10mn30s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit d9994bea7d) - ❌

⏲️ Total pipeline duration: 10mn20s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit 76b3417181) - ❌

⏲️ Total pipeline duration: 10mn21s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@davydov-d
Copy link
Collaborator Author

/approve-and-merge --reason "Tests fail because of abusive CI caching; all the tests pass locally."

@octavia-approvington
Copy link
Contributor

Trying to merge your PR using a bot?
Comment this on the PR:

/approve-and-merge reason="<STATE YOUR REASON HERE>"

Make sure you've reviewed the docs!

@davydov-d
Copy link
Collaborator Author

/approve-and-merge reason="Tests fail because of abusive CI caching; all the tests pass locally."

@octavia-approvington
Copy link
Contributor

After a careful ML study,
we think this looks okay.
imagine code being okay

@octavia-approvington octavia-approvington merged commit a4e0f20 into master Jul 3, 2023
20 of 25 checks passed
@octavia-approvington octavia-approvington deleted the ddavydov/#2294-source-hubspot-use-fully-qualified-name-for-custom-objects branch July 3, 2023 07:27
@alafanechere alafanechere restored the ddavydov/#2294-source-hubspot-use-fully-qualified-name-for-custom-objects branch July 3, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants