New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Destination Meilisearch: fix incomplete data indexing #27692
🐛 Destination Meilisearch: fix incomplete data indexing #27692
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Hey @alallema I don't want to step on your toes on this. I ran into this problem myself and for some reason missed the gh issue and this PR 😅 I've created a solution as well, taking a slightly different approach, that I think is a bit simpler. You can see in this PR on my fork gmanninglive#1 Anyway I fully endorse this fix being released as it's an annoying bug 🐛 |
Hi @gmanninglive, |
Sorry for the long delay in getting this reviewed and merged. Our team is currently finishing the August Hackathon review contributions over the next two weeks, and after that, we will return to the community backlog. |
Hello @alallema I'll start the review during this week. Sorry the lack of updates. Thanks for the patience. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
What
Even if all the indexes were created in Meilisearch, only one was correctly synchronized with its data.
Closes #19205
How
steam_name
tostream_name
wait_for_task
method from the codeRecommended reading order
destination.py
writer.py
unit_test.py
meilisearch.md
🚨 User Impact 🚨
I hope none other than that it should work properly.
Bump versioning as Patch:
1.0.0
to1.0.1
due to simple bug fixes.Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.