Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination Meilisearch: fix incomplete data indexing #27692

Conversation

alallema
Copy link
Contributor

What

Even if all the indexes were created in Meilisearch, only one was correctly synchronized with its data.
Closes #19205

How

  • Removing the message loop from the configured_catalog stream loop
  • Add debug log
  • Fix typo from steam_name to stream_name
  • Move the writing buffer from Class to initialization of the Class
  • Add a method for flushing all streams at once
  • Remove the wait_for_task method from the code
  • Adapt the tests

Recommended reading order

  1. destination.py
  2. writer.py
  3. unit_test.py
  4. meilisearch.md

🚨 User Impact 🚨

I hope none other than that it should work properly.
Bump versioning as Patch: 1.0.0 to 1.0.1 due to simple bug fixes.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/meilisearch labels Jun 25, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@gmanninglive
Copy link
Contributor

Hey @alallema I don't want to step on your toes on this. I ran into this problem myself and for some reason missed the gh issue and this PR 😅

I've created a solution as well, taking a slightly different approach, that I think is a bit simpler. You can see in this PR on my fork gmanninglive#1

Anyway I fully endorse this fix being released as it's an annoying bug 🐛

@alallema
Copy link
Contributor Author

Hi @gmanninglive,
No worries, on the contrary, thanks for trying to fix it too 😄
And I agree, this bug is annoying 😞

@marcosmarxm
Copy link
Member

Sorry for the long delay in getting this reviewed and merged. Our team is currently finishing the August Hackathon review contributions over the next two weeks, and after that, we will return to the community backlog.

@marcosmarxm
Copy link
Member

Hello @alallema I'll start the review during this week. Sorry the lack of updates. Thanks for the patience.

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 10:00pm

@marcosmarxm marcosmarxm merged commit 22caddd into airbytehq:master Dec 18, 2023
33 of 42 checks passed
@alallema alallema deleted the fix/destination-meilisearch_incomplete-data-indexing branch December 19, 2023 12:23
timroes pushed a commit that referenced this pull request Dec 19, 2023
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/meilisearch
Projects
Development

Successfully merging this pull request may close these issues.

Destination Meilisearch: incomplete data indexed
5 participants