Source Prestashop: Fix schema, remove empty datetime fields #27716

artem1205 · 2023-06-26T18:47:45Z

What

Fix Source Prestashop

How

Fix expected records

🚨 User Impact 🚨

quantity schema changed; schema update required

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

github-actions · 2023-06-26T18:48:06Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
The connector tests are passing in CI
You've updated the connector's metadata.yaml file (new!)
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

davydov-d

we should bump major version here

davydov-d · 2023-06-26T18:58:14Z

airbyte-integrations/connectors/source-prestashop/source_prestashop/schemas/combinations.json

@@ -24,7 +24,7 @@
      "type": "string"
    },
    "quantity": {
-      "type": "string"
+      "type": ["null", "integer"]


this is a breaking change :(

octavia-squidington-iii · 2023-06-26T19:13:36Z

source-prestashop test report (commit `7a8b462a25`) - ❌

⏲️ Total pipeline duration: 1273 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

octavia-squidington-iii · 2023-06-26T19:35:22Z

source-prestashop test report (commit `7a8b462a25`) - ❌

⏲️ Total pipeline duration: 1201 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

octavia-squidington-iii · 2023-06-26T19:55:22Z

source-prestashop test report (commit `de462156a6`) - ❌

⏲️ Total pipeline duration: 1121 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

octavia-squidington-iii · 2023-06-26T20:17:16Z

source-prestashop test report (commit `16bf98dd4c`) - ❌

⏲️ Total pipeline duration: 1087 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

octavia-squidington-iii · 2023-06-27T12:23:29Z

source-prestashop test report (commit `ca63723e0c`) - ❌

⏲️ Total pipeline duration: 83 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

octavia-squidington-iii · 2023-06-27T12:26:14Z

source-prestashop test report (commit `ca63723e0c`) - ❌

⏲️ Total pipeline duration: 62 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

octavia-squidington-iii · 2023-06-27T13:14:31Z

source-prestashop test report (commit `831d25c0d3`) - ❌

⏲️ Total pipeline duration: 1090 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

octavia-squidington-iii · 2023-06-27T13:40:47Z

source-prestashop test report (commit `9cd3e19545`) - ❌

⏲️ Total pipeline duration: 1104 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

octavia-squidington-iii · 2023-06-27T15:02:42Z

source-prestashop test report (commit `bdc9515c7d`) - ✅

⏲️ Total pipeline duration: 1097 seconds

Step	Result
Validate airbyte-integrations/connectors/source-prestashop/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-prestashop docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-prestashop test

artem1205 added 2 commits June 26, 2023 19:27

Source Prestashop: update schema; remove empty datetime fields

eb07bd7

Source Prestashop: update expected_records

610c54a

octavia-squidington-iii added area/connectors Connector related issues connectors/source/prestashop labels Jun 26, 2023

Source Prestashop: update docs

7a8b462

artem1205 self-assigned this Jun 26, 2023

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 26, 2023

artem1205 requested review from davydov-d and lazebnyi June 26, 2023 18:49

artem1205 marked this pull request as ready for review June 26, 2023 18:49

davydov-d approved these changes Jun 26, 2023

View reviewed changes

artem1205 added 2 commits June 26, 2023 21:34

Source Prestashop: update schemas

ffe3a8b

Source Prestashop: fix backward compatibility

de46215

Source Prestashop: bump version

16bf98d

artem1205 marked this pull request as draft June 26, 2023 20:35

artem1205 added 2 commits June 26, 2023 22:35

Source Prestashop: update expected_records

7cbfd77

Source Prestashop: update test config

ca63723

artem1205 marked this pull request as ready for review June 27, 2023 12:20

Source Prestashop: update test config

831d25c

Source Prestashop: update expected records

9cd3e19

Source Prestashop: update expected_records

bdc9515

artem1205 merged commit 16d7701 into master Jun 27, 2023
21 of 22 checks passed

artem1205 deleted the artem1205/con-health-prestashop branch June 27, 2023 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Prestashop: Fix schema, remove empty datetime fields #27716

Source Prestashop: Fix schema, remove empty datetime fields #27716

artem1205 commented Jun 26, 2023

github-actions bot commented Jun 26, 2023 •

edited by artem1205

davydov-d left a comment

davydov-d Jun 26, 2023

octavia-squidington-iii commented Jun 26, 2023

octavia-squidington-iii commented Jun 26, 2023

octavia-squidington-iii commented Jun 26, 2023

octavia-squidington-iii commented Jun 26, 2023

octavia-squidington-iii commented Jun 27, 2023

octavia-squidington-iii commented Jun 27, 2023

octavia-squidington-iii commented Jun 27, 2023

octavia-squidington-iii commented Jun 27, 2023

octavia-squidington-iii commented Jun 27, 2023

Source Prestashop: Fix schema, remove empty datetime fields #27716

Source Prestashop: Fix schema, remove empty datetime fields #27716

Conversation

artem1205 commented Jun 26, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

github-actions bot commented Jun 26, 2023 • edited by artem1205

Before Merging a Connector Pull Request

davydov-d left a comment

Choose a reason for hiding this comment

davydov-d Jun 26, 2023

Choose a reason for hiding this comment

octavia-squidington-iii commented Jun 26, 2023

source-prestashop test report (commit 7a8b462a25) - ❌

octavia-squidington-iii commented Jun 26, 2023

source-prestashop test report (commit 7a8b462a25) - ❌

octavia-squidington-iii commented Jun 26, 2023

source-prestashop test report (commit de462156a6) - ❌

octavia-squidington-iii commented Jun 26, 2023

source-prestashop test report (commit 16bf98dd4c) - ❌

octavia-squidington-iii commented Jun 27, 2023

source-prestashop test report (commit ca63723e0c) - ❌

octavia-squidington-iii commented Jun 27, 2023

source-prestashop test report (commit ca63723e0c) - ❌

octavia-squidington-iii commented Jun 27, 2023

source-prestashop test report (commit 831d25c0d3) - ❌

octavia-squidington-iii commented Jun 27, 2023

source-prestashop test report (commit 9cd3e19545) - ❌

octavia-squidington-iii commented Jun 27, 2023

source-prestashop test report (commit bdc9515c7d) - ✅

github-actions bot commented Jun 26, 2023 •

edited by artem1205

source-prestashop test report (commit `7a8b462a25`) - ❌

source-prestashop test report (commit `7a8b462a25`) - ❌

source-prestashop test report (commit `de462156a6`) - ❌

source-prestashop test report (commit `16bf98dd4c`) - ❌

source-prestashop test report (commit `ca63723e0c`) - ❌

source-prestashop test report (commit `ca63723e0c`) - ❌

source-prestashop test report (commit `831d25c0d3`) - ❌

source-prestashop test report (commit `9cd3e19545`) - ❌

source-prestashop test report (commit `bdc9515c7d`) - ✅