Skip to content

Facebook Pages and Facebook Marketing connector license to Elv2 - #27728

Merged
Octavia The Approver (octavia-approvington) merged 2 commits into
masterfrom
evan/elv2-facebook
Jun 27, 2023
Merged

Facebook Pages and Facebook Marketing connector license to Elv2#27728
Octavia The Approver (octavia-approvington) merged 2 commits into
masterfrom
evan/elv2-facebook

Conversation

@evantahler

@evantahler Evan Tahler (evantahler) commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

See #27724

@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 26, 2023
@github-actions

github-actions Bot commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-facebook-pages test report (commit e5a9d29b12) - ❌

⏲️ Total pipeline duration: 548 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-pages/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-facebook-pages docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-pages test

@evantahler

Copy link
Copy Markdown
Contributor Author

Note: source-facebook-pages is failing on master.

@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-facebook-marketing test report (commit e5a9d29b12) - ✅

⏲️ Total pipeline duration: 3697 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@evantahler

Copy link
Copy Markdown
Contributor Author

/approve-and-merge reason="connector licenses to Elv2 - FB tests are already failing on master"

@octavia-approvington

Copy link
Copy Markdown
Contributor

Myomoto says it looks good
thats a niiice

@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-facebook-pages test report (commit 30bd010218) - ❌

⏲️ Total pipeline duration: 487 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-pages/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-facebook-pages docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-pages test

@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-facebook-marketing test report (commit 30bd010218) - ❌

⏲️ Total pipeline duration: 3189 seconds

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants