-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Mixpanel: reimplement backoff strategy #27752
🐛 Source Mixpanel: reimplement backoff strategy #27752
Conversation
…-backoff-strategy
…tegy' of github.com:airbytehq/airbyte into ddavydov/#2363-source-mixpanel-reimplement-backoff-strategy
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ❌ |
Connector package install | ✅ |
Build source-stripe docker image for platform linux/x86_64 | ✅ |
Unit tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-stripe test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-mixpanel/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-mixpanel docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-mixpanel test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-mixpanel/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-mixpanel docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-mixpanel test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-mixpanel/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ❌ |
Connector package install | ✅ |
Build source-mixpanel docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-mixpanel test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-mixpanel/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-mixpanel docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-mixpanel test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-mixpanel/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-mixpanel docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-mixpanel test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-mixpanel/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-mixpanel docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-mixpanel test
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds * Add stream ShippingRates * airbytehq#2363 source mixpanel: reimplement backoff strategy * airbytehq#2363 source mixpanel: upd changelog * airbytehq#2363 source mixpanel: revert v0.1.32 * rework rate limits * wait only when running CAT + increase timeouts * airbytehq#2363 return backoff time * code format * use env variable instead of a hidden field in the config * review comments * review fixes * fix reading env var * Resolve conflicts, Bump version * Attempt to bump version to avoid caching * split test config into to projects * rollback version * undo non related changes * remove non related changes * revert new line * fix funnel slice patching * fix funnel slice patching * do not use stream state for generating request params! * fix updating state * Revert "do not use stream state for generating request params!" This reverts commit 443781e. * revert prev commits * fix timestamp filtering --------- Co-authored-by: btkcodedev <btk.codedev@gmail.com> Co-authored-by: Augustin <augustin@airbyte.io> Co-authored-by: maxi297 <maxime@airbyte.io>
What
https://github.com/airbytehq/oncall/issues/2363
How
The root cause of the issue is we're exceeding the number of retries because we're exceeding the rate limits. Therefore:
This brings in a contradictory condition: one one hand we should wait after each api call, on the other hand the connector can time out when running CAT or during
check()
ordiscover()
regarding changes made in version 0.1.35 (extra api calls added for bothcheck()
anddiscover()
). That's why more changes were made:check
anddiscover
increased in the CAT configcheck
ordiscover
only in prod mode (do sleep when running tests)upd:
Export
stream's cursor field istime
, notdate
🚨 User Impact 🚨
No negative impact