🐛 Source Square: update following state management changes in the CDK #27762

maxi297 · 2023-06-27T15:25:07Z

What

Breaking changes were done as part of a45a1e3. This PR fixes the breaking changes for square.

How

Updating the interfaces that were affected by breaking changes.

🚨 User Impact 🚨

None as the code should have the exact same behavior

github-actions · 2023-06-27T15:25:28Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
The connector tests are passing in CI
You've updated the connector's metadata.yaml file (new!)
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

octavia-squidington-iii · 2023-06-27T19:01:36Z

source-square test report (commit `6fd5b8f3f2`) - ❌

⏲️ Total pipeline duration: 54 seconds

Step	Result
Validate airbyte-integrations/connectors/source-square/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-square docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-square test

maxi297 · 2023-06-27T19:44:09Z

airbyte-integrations/connectors/source-square/unit_tests/test_component.py

    else:
        assert actual_stream_slice == expected_stream_slice
-        slicer.update_cursor(stream_slice=actual_stream_slice, last_record=last_record)
+        slicer.update_state(stream_slice=actual_stream_slice, last_record=last_record)


The previous test never actually updated the state using state but only using actual_stream_slice which didn't have the abnormally high updated_at=2200-01-01T00:00:00.000000Z. Therefore, this assertion didn't test anything

octavia-squidington-iii · 2023-06-27T20:07:32Z

source-square test report (commit `1624c39d8e`) - ❌

⏲️ Total pipeline duration: 1238 seconds

Step	Result
Validate airbyte-integrations/connectors/source-square/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅
Code format checks	❌
Connector package install	✅
Build source-square docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-square test

octavia-squidington-iii · 2023-06-27T20:29:46Z

source-square test report (commit `0937388616`) - ✅

⏲️ Total pipeline duration: 1248 seconds

Step	Result
Validate airbyte-integrations/connectors/source-square/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-square docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-square test

octavia-squidington-iii · 2023-06-29T15:07:00Z

source-square test report (commit `bc9f5ff721`) - ❌

⏲️ Total pipeline duration: 60 seconds

Step	Result
Validate airbyte-integrations/connectors/source-square/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-square docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-square test

octavia-squidington-iii · 2023-06-29T15:28:02Z

source-square test report (commit `35787de568`) - ❌

⏲️ Total pipeline duration: 1079 seconds

Step	Result
Validate airbyte-integrations/connectors/source-square/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-square docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-square test

octavia-squidington-iii · 2023-06-29T18:42:26Z

source-square test report (commit `fe56f515df`) - ✅

⏲️ Total pipeline duration: 21mn43s

Step	Result
Validate airbyte-integrations/connectors/source-square/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-square docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-square test

Update square stream_slices

6fd5b8f

octavia-squidington-iii added the area/connectors Connector related issues label Jun 27, 2023

octavia-squidington-iii added the connectors/source/square label Jun 27, 2023

maxi297 changed the title ~~Update square stream_slices~~ 🐛 Source Square: update following state management changes in the CDK Jun 27, 2023

maxi297 marked this pull request as ready for review June 27, 2023 18:55

Fix unit tests

1624c39

maxi297 commented Jun 27, 2023

View reviewed changes

maxi297 added 3 commits June 27, 2023 15:51

Version bump and changelogs

0d382c9

Update changelogs

10e1f7b

Format code

0937388

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 27, 2023

maxi297 added checklist-action-run and removed checklist-action-run labels Jun 27, 2023

maxi297 requested a review from artem1205 June 28, 2023 18:37

Merge branch 'master' into maxi297-state-changes/square

9307f5c

artem1205 approved these changes Jun 28, 2023

View reviewed changes

Update CDK version to fix bug

bc9f5ff

Fix unit tests

35787de

maxi297 added 2 commits June 29, 2023 11:48

Merge branch 'master' into maxi297-state-changes/square

b554811

Increase CDK version

fe56f51

maxi297 merged commit e8ddda9 into master Jun 29, 2023
20 checks passed

maxi297 deleted the maxi297-state-changes/square branch June 29, 2023 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Square: update following state management changes in the CDK #27762

🐛 Source Square: update following state management changes in the CDK #27762

maxi297 commented Jun 27, 2023 •

edited

github-actions bot commented Jun 27, 2023 •

edited by maxi297

octavia-squidington-iii commented Jun 27, 2023

maxi297 Jun 27, 2023

octavia-squidington-iii commented Jun 27, 2023

octavia-squidington-iii commented Jun 27, 2023

octavia-squidington-iii commented Jun 29, 2023

octavia-squidington-iii commented Jun 29, 2023

octavia-squidington-iii commented Jun 29, 2023

🐛 Source Square: update following state management changes in the CDK #27762

🐛 Source Square: update following state management changes in the CDK #27762

Conversation

maxi297 commented Jun 27, 2023 • edited

What

How

🚨 User Impact 🚨

github-actions bot commented Jun 27, 2023 • edited by maxi297

Before Merging a Connector Pull Request

octavia-squidington-iii commented Jun 27, 2023

source-square test report (commit 6fd5b8f3f2) - ❌

maxi297 Jun 27, 2023

Choose a reason for hiding this comment

octavia-squidington-iii commented Jun 27, 2023

source-square test report (commit 1624c39d8e) - ❌

octavia-squidington-iii commented Jun 27, 2023

source-square test report (commit 0937388616) - ✅

octavia-squidington-iii commented Jun 29, 2023

source-square test report (commit bc9f5ff721) - ❌

octavia-squidington-iii commented Jun 29, 2023

source-square test report (commit 35787de568) - ❌

octavia-squidington-iii commented Jun 29, 2023

source-square test report (commit fe56f515df) - ✅

maxi297 commented Jun 27, 2023 •

edited

github-actions bot commented Jun 27, 2023 •

edited by maxi297

source-square test report (commit `6fd5b8f3f2`) - ❌

source-square test report (commit `1624c39d8e`) - ❌

source-square test report (commit `0937388616`) - ✅

source-square test report (commit `bc9f5ff721`) - ❌

source-square test report (commit `35787de568`) - ❌

source-square test report (commit `fe56f515df`) - ✅