Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Posthog: update following state management changes in the CDK #27764

Merged
merged 8 commits into from Jun 29, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jun 27, 2023

What

Breaking changes were done as part of a45a1e3. This PR fixes the breaking changes for posthog.

How

Updating the interfaces that were affected by breaking changes.

🚨 User Impact 🚨

None as the code should have the exact same behavior

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@maxi297 maxi297 changed the title Update posthog per partition implementation 🐛 Source Posthog: update following state management changes in the CDK Jun 27, 2023
@maxi297 maxi297 force-pushed the maxi297-state-changes/posthog branch from 7fc5eb1 to d6a5a7c Compare June 28, 2023 16:24
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 28, 2023
@maxi297 maxi297 marked this pull request as ready for review June 28, 2023 18:36
@maxi297 maxi297 requested a review from artem1205 June 28, 2023 18:37
@octavia-squidington-iii
Copy link
Collaborator

source-posthog test report (commit d4ae093e12) - ❌

⏲️ Total pipeline duration: 57 seconds

Step Result
Validate airbyte-integrations/connectors/source-posthog/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-posthog docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-posthog test

@octavia-squidington-iii
Copy link
Collaborator

source-posthog test report (commit 9e79f40568) - ❌

⏲️ Total pipeline duration: 319 seconds

Step Result
Validate airbyte-integrations/connectors/source-posthog/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-posthog docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-posthog test

@octavia-squidington-iii
Copy link
Collaborator

source-posthog test report (commit ecb200c1da) - ✅

⏲️ Total pipeline duration: 363 seconds

Step Result
Validate airbyte-integrations/connectors/source-posthog/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-posthog docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-posthog test

@octavia-squidington-iii
Copy link
Collaborator

source-posthog test report (commit 0ee8ace5c8) - ❌

⏲️ Total pipeline duration: 263 seconds

Step Result
Validate airbyte-integrations/connectors/source-posthog/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-posthog docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-posthog test

@octavia-squidington-iii
Copy link
Collaborator

source-posthog test report (commit f2e4381af4) - ❌

⏲️ Total pipeline duration: 644 seconds

Step Result
Validate airbyte-integrations/connectors/source-posthog/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-posthog docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-posthog test

@octavia-squidington-iii
Copy link
Collaborator

source-posthog test report (commit 37254cdae8) - ✅

⏲️ Total pipeline duration: 391 seconds

Step Result
Validate airbyte-integrations/connectors/source-posthog/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-posthog docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-posthog test

@maxi297 maxi297 merged commit 96aa72d into master Jun 29, 2023
21 checks passed
@maxi297 maxi297 deleted the maxi297-state-changes/posthog branch June 29, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/posthog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants