Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Google Search Console: add new streams #27831

Merged

Conversation

darynaishchenko
Copy link
Collaborator

What

Adding new streams:
new stream Keyword Site Report by page
new stream Keyword Page Report
new stream Site Report by page
new stream Site Report by site
new stream Page Report

How

For streams based on Keyword, uses class SearchAppearance, that gets records by SearchAppearance dimension, value of this dimension uses in filtering after.
Site Report and Page Report use appropriate dimensions and aggregation type.

@darynaishchenko darynaishchenko self-assigned this Jun 29, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@darynaishchenko darynaishchenko changed the title :Source Google Search Console: add new streams ✨Source Google Search Console: add new streams Jun 29, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-google-search-console test report (commit 247468320c) - ✅

⏲️ Total pipeline duration: 16mn06s

Step Result
Validate airbyte-integrations/connectors/source-google-search-console/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-search-console docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-search-console test

@octavia-squidington-iii
Copy link
Collaborator

source-google-search-console test report (commit 4aac5bfa5b) - ❌

⏲️ Total pipeline duration: 15mn17s

Step Result
Validate airbyte-integrations/connectors/source-google-search-console/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-search-console docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-search-console test

@octavia-squidington-iii
Copy link
Collaborator

source-google-search-console test report (commit d7d63348a2) - ❌

⏲️ Total pipeline duration: 14mn19s

Step Result
Validate airbyte-integrations/connectors/source-google-search-console/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-search-console docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-search-console test

@octavia-squidington-iii
Copy link
Collaborator

source-google-search-console test report (commit d2cffe5fbd) - ✅

⏲️ Total pipeline duration: 13mn42s

Step Result
Validate airbyte-integrations/connectors/source-google-search-console/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-search-console docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-search-console test

@lazebnyi lazebnyi removed the request for review from brianjlai June 30, 2023 11:51
@darynaishchenko darynaishchenko merged commit a08911e into master Jun 30, 2023
21 of 22 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-google-search-console/add-new-streams branch June 30, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants