Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 🚨 Source Amazon Ads: fix schemas #27868

Merged
merged 88 commits into from Jul 24, 2023

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Jun 30, 2023

What

https://github.com/airbytehq/oncall/issues/1955

How

Fix attribution report stream schemas:

  • exclude current upper level properties (cusrorId, size)
  • dynamically include metrics

🚨 User Impact 🚨

This is a breaking change because schemas of 4 streams are changing dramatically

@octavia-squidington-iii
Copy link
Collaborator

source-amazon-ads test report (commit 6b557d7d27) - ❌

⏲️ Total pipeline duration: 03mn19s

Step Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-amazon-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-amazon-ads test report (commit be6fa1c657) - ✅

⏲️ Total pipeline duration: 03mn16s

Step Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-amazon-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

@sherifnada sherifnada removed the request for review from a team July 13, 2023 23:02
@octavia-squidington-iii
Copy link
Collaborator

source-amazon-ads test report (commit 1c2c9e320d) - ✅

⏲️ Total pipeline duration: 4.68s

Step Result

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-amazon-ads test report (commit 3eb3e6725c) - ❌

⏲️ Total pipeline duration: 03mn15s

Step Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-amazon-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-amazon-ads test report (commit 6385619f5b) - ❌

⏲️ Total pipeline duration: 02mn48s

Step Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-amazon-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-amazon-ads test report (commit 5d9d706483) - ✅

⏲️ Total pipeline duration: 05mn00s

Step Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-amazon-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

@davydov-d davydov-d merged commit ccac29a into master Jul 24, 2023
22 checks passed
@davydov-d davydov-d deleted the ddavydov/#1955-source-amazon-ads-fix-schemas branch July 24, 2023 13:29
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* airbytehq#1955 source amazon ads: fix stream schemas

* source amazon ads: upd changelog

* source amazon ads: upd CAT config

* upd backwards incompatible version

* update metadata with breakingChanges entry

* fix CATs

* fix md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation breaking-change Don't merge me unless you are ready. checklist-action-run connectors/source/amazon-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants