Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Google Analytics Data API: limit custom report page size #27909

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/2277

How

We tried limiting the page size in this PR but that was a wrong stream - metadata instead of custom report. Now, having changed the page size for the correct stream, locally it takes 50MB instead of 250MB to perform a check. So,

  • Change the page size of custom reports streams
  • Remove resource overrides
  • Do not log error if it is empty

🚨 User Impact 🚨

No negative impact

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-data-api test report (commit a11c906e40) - ❌

⏲️ Total pipeline duration: 67mn01s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-data-api/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-analytics-data-api docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-data-api test

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-data-api test report (commit 487df66c0c) - ❌

⏲️ Total pipeline duration: 66mn49s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-data-api/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-analytics-data-api docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-data-api test

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-data-api test report (commit 065262ee0e) - ✅

⏲️ Total pipeline duration: 29mn03s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-data-api/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-analytics-data-api docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-data-api test

@davydov-d davydov-d merged commit e9fba26 into master Jul 3, 2023
24 of 25 checks passed
@davydov-d davydov-d deleted the ddavydov/#2277-source-google-analytics-limit-custom-report-page-size branch July 3, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants