Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Close.com: add human readable titles to api-key and `start_d… #27950

Merged
merged 6 commits into from Jul 11, 2023
Merged

Source Close.com: add human readable titles to api-key and `start_d… #27950

merged 6 commits into from Jul 11, 2023

Conversation

ChristoGrab
Copy link
Contributor

What

  • Added api-key title: API Key
  • Added start_date title: Replication Start Date

@ChristoGrab
Source Close.com: add human readable titles to api-key and `start_d…
7c251b2 
…ate` fields

- Added `api-key` title: `API Key`
- Added `start_date` title: `Replication Start Date`
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023 •
edited by ChristoGrab

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-close-com test report (commit 7c251b2382) - ❌

⏲️ Total pipeline duration: 06mn57s

Step Result
Validate airbyte-integrations/connectors/source-close-com/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ❌
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-close-com docker image for platform linux/x86_64 ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-close-com test

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 5, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-close-com test report (commit ba1357420f) - ✅

⏲️ Total pipeline duration: 06mn45s

Step Result
Validate airbyte-integrations/connectors/source-close-com/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-close-com docker image for platform linux/x86_64 ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-close-com test

@octavia-squidington-iii
Copy link
Collaborator

source-close-com test report (commit ba1357420f) - ✅

⏲️ Total pipeline duration: 05mn45s

Step Result
Validate airbyte-integrations/connectors/source-close-com/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-close-com docker image for platform linux/x86_64 ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-close-com test

sherifnada
sherifnada approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

airbyte-integrations/connectors/source-close-com/source_close_com/spec.json Outdated Show resolved Hide resolved
@ChristoGrab @sherifnada
Update airbyte-integrations/connectors/source-close-com/source_close_…
d95c2c4 
…com/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@octavia-squidington-iii
Copy link
Collaborator

source-close-com test report (commit d95c2c4469) - ✅

⏲️ Total pipeline duration: 06mn51s

Step Result
Validate airbyte-integrations/connectors/source-close-com/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-close-com docker image for platform linux/x86_64 ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-close-com test

@ChristoGrab ChristoGrab merged commit 9217c12 into master Jul 11, 2023
21 checks passed
@ChristoGrab ChristoGrab deleted the ChristoGrab-close-com-title-fix branch July 11, 2023 15:48
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@ChristoGrab @sherifnada @efimmatytsin
Source Close.com: add human readable titles to api-key and `start_d… (
e6e6ec6 
airbytehq#27950)

* Source Close.com: add human readable titles to `api-key` and `start_date` fields 

- Added `api-key` title: `API Key`
- Added `start_date` title: `Replication Start Date`

* update version to 0.4.1 in metadata.yaml

* update version to 0.4.1 in Dockerfile

* update close-com.md changelog to 0.4.1

* Update airbyte-integrations/connectors/source-close-com/source_close_com/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

---------

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/close-com
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristoGrab @octavia-squidington-iii @sherifnada