Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination Clickhouse: fix clickhouse-dbt timeout #27958

Closed
wants to merge 2 commits into from
Closed

🐛 Destination Clickhouse: fix clickhouse-dbt timeout #27958

wants to merge 2 commits into from

Conversation

fgarci03
Copy link

@fgarci03 fgarci03 commented Jul 4, 2023

What

clickhouse-dbt read timeout is set to 300s without possibility of customization

How

Use the JDBC configuration to allow setting the timeout to a different value

🚨 User Impact 🚨

No breaking changes. It just allows setting a different read timeout if the socket_timeout param is passed in the JDBC params

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Closes #23880

@fgarci03 fgarci03 requested a review from a team as a code owner July 4, 2023 22:17
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2023

CLA assistant check
All committers have signed the CLA.

@evantahler
Copy link
Contributor

I've closed this PR as we are deprecating dbt-based normalization. Learn more here #26028

@evantahler evantahler closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Destination Clickhouse: Timeout clickhouse-dbt v1.4.0
4 participants