-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Facebook Marketing: restore reduced request record limit after successful
response
#27979
🐛 Source Facebook Marketing: restore reduced request record limit after successful
response
#27979
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
…ting-restore-req-limit-after-200
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
What
Resolving:
How
request_record_limit_is_reduced
andlast_api_call_is_successfull
to manage the state of the flow in theapi.py
_should_restore_default_page_size
method toapi.py
to check whether the revert process should be triggeredcall
method to check for reverting conditions and inject thedefault_page_size
api.py
__init___
method to provide theapi.py
module with theconfig.page_size
value supplied by the customer and further use it as thedefault_page_size
attribute.backoff_policy
with"An unknown error occurred"
error pattern to track inreduce_request_record_limit
fromcommon.py
revert_request_record_limit
method tocommon.py
to handlebackoff(...on_success=...)
scenario.Recommended reading order
y.python
🚨 User Impact 🚨
No user impact is expected - no breaking changes.