-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Zendesk: add streams: PostVotes
, PostCommentVotes
#27991
Source Zendesk: add streams: PostVotes
, PostCommentVotes
#27991
Conversation
…source-zendesk-support-votes-16910
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
# Conflicts: # airbyte-integrations/connectors/source-zendesk-support/acceptance-test-config.yml # airbyte-integrations/connectors/source-zendesk-support/integration_tests/configured_catalog.json # airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/source.py # airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py # airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py
source-zendesk-support test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-zendesk-support docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-zendesk-support test
source-zendesk-support test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-zendesk-support docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-zendesk-support test
What
Resolving #16910
How
Add streams:
PostVotes
PostCommentVotes
Recommended reading order
streams.py
🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.