🎉 Amazon Ads - new streams for bids and keyword recommendations #28002

midavadim · 2023-07-06T09:46:07Z

What

SponsoredProductAdGroupSuggestedKeywords:
Latest API:
https://advertising.amazon.com/API/docs/en-us/sponsored-products/3-0/openapi/prod#/Keyword%20Targets/getRankedKeywordRecommendation
POST /sp/targets/keywords/recommendations
Note: does not work, always get "403 Forbidden"

V2 API:
https://advertising.amazon.com/API/docs/en-us/sponsored-products/2-0/openapi#/Suggested%20keywords
GET /v2/sp/adGroups/{{adGroupId}}>/suggested/keywords

SponsoredProductAdGroupBidRecommendations:
Latest API:
https://advertising.amazon.com/API/docs/en-us/sponsored-display/3-0/openapi#/Bid%20Recommendations/getTargetBidRecommendations
POST /sd/targets/bid/recommendations
Note: does not work, always get "403 Forbidden"

V2 API:
https://advertising.amazon.com/API/docs/en-us/sponsored-products/2-0/openapi#/Bid%20recommendations/getAdGroupBidRecommendations
GET /v2/sp/adGroups/{adGroupId}/bidRecommendations

🚨 User Impact 🚨

No

github-actions · 2023-07-06T09:46:26Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
The connector tests are passing in CI
You've updated the connector's metadata.yaml file (new!)
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

…keyword_recommendations # Conflicts: # airbyte-integrations/connectors/source-amazon-ads/integration_tests/expected_records.jsonl # docs/integrations/sources/amazon-ads.md

…keyword_recommendations

midavadim · 2023-07-06T13:46:22Z

/test connector=connectors/source-amazon-ads

⚠️ The test slash command is now deprecated.

The connector tests are automatically triggered as CI checks.

Please use /legacy-test if you need to test CDK or CAT changes.

Please join post to #pipeline-complaint-hotline slack channel if something is not working as expected.

octavia-squidington-iii · 2023-07-06T13:56:28Z

source-amazon-ads test report (commit `9a7e9b61a2`) - ✅

⏲️ Total pipeline duration: 03mn40s

Step	Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

lazebnyi

Can not find version bump for metadata and docker.

octavia-squidington-iii · 2023-07-06T14:49:43Z

source-amazon-ads test report (commit `9a7e9b61a2`) - ✅

⏲️ Total pipeline duration: 03mn41s

Step	Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

…roup_bids_keyword_recommendations' into midavadim/26400_26402_amazon_adgroup_bids_keyword_recommendations

…keyword_recommendations

midavadim · 2023-07-06T15:47:54Z

Can not find version bump for metadata and docker.

updated again, it disappeared after merge

airbyte-integrations/connectors/source-amazon-ads/Dockerfile

…roup_bids_keyword_recommendations' into midavadim/26400_26402_amazon_adgroup_bids_keyword_recommendations

…keyword_recommendations

octavia-squidington-iii · 2023-07-06T17:18:26Z

source-amazon-ads test report (commit `10b52eb9f7`) - ✅

⏲️ Total pipeline duration: 03mn32s

Step	Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

octavia-squidington-iii · 2023-07-06T18:45:50Z

source-amazon-ads test report (commit `d178fbaa41`) - ✅

⏲️ Total pipeline duration: 03mn05s

Step	Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

added new streams for amazon adgroup bids keyword recommendations

b315a01

octavia-squidington-iii added the area/connectors Connector related issues label Jul 6, 2023

octavia-squidington-iii added the connectors/source/amazon-ads label Jul 6, 2023

updated docs and configured catalog

ce4e47b

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 6, 2023

updated version in metadata

b6e1713

This was linked to issues Jul 6, 2023

Source Amazon Ads: new stream Bid recommendations #26402

Closed

Source Amazon Ads: new stream Suggested keywords #26400

Closed

midavadim requested a review from lazebnyi July 6, 2023 10:39

midavadim added 6 commits July 6, 2023 13:46

Merge branch 'master' into midavadim/26400_26402_amazon_adgroup_bids_…

ef89069

…keyword_recommendations # Conflicts: # airbyte-integrations/connectors/source-amazon-ads/integration_tests/expected_records.jsonl # docs/integrations/sources/amazon-ads.md

fix test

fa2e0e6

updated docs

2602556

fix doc after merge

d36c01f

fix comments

7045de0

Merge branch 'master' into midavadim/26400_26402_amazon_adgroup_bids_…

9a7e9b6

…keyword_recommendations

lazebnyi reviewed Jul 6, 2023

View reviewed changes

midavadim added 3 commits July 6, 2023 18:45

updated version

a3b3449

Merge remote-tracking branch 'origin/midavadim/26400_26402_amazon_adg…

2c28384

…roup_bids_keyword_recommendations' into midavadim/26400_26402_amazon_adgroup_bids_keyword_recommendations

Merge branch 'master' into midavadim/26400_26402_amazon_adgroup_bids_…

033d95f

…keyword_recommendations

lazebnyi requested changes Jul 6, 2023

View reviewed changes

airbyte-integrations/connectors/source-amazon-ads/Dockerfile Outdated Show resolved Hide resolved

midavadim added 2 commits July 6, 2023 18:51

fux typo

3f54468

Merge remote-tracking branch 'origin/midavadim/26400_26402_amazon_adg…

182e979

…roup_bids_keyword_recommendations' into midavadim/26400_26402_amazon_adgroup_bids_keyword_recommendations

midavadim requested a review from lazebnyi July 6, 2023 15:52

lazebnyi approved these changes Jul 6, 2023

View reviewed changes

Merge branch 'master' into midavadim/26400_26402_amazon_adgroup_bids_…

762c325

…keyword_recommendations

midavadim enabled auto-merge (squash) July 6, 2023 15:56

Merge branch 'master' into midavadim/26400_26402_amazon_adgroup_bids_…

10b52eb

…keyword_recommendations

midavadim merged commit d180215 into master Jul 6, 2023
20 of 21 checks passed

midavadim deleted the midavadim/26400_26402_amazon_adgroup_bids_keyword_recommendations branch July 6, 2023 17:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Amazon Ads - new streams for bids and keyword recommendations #28002

🎉 Amazon Ads - new streams for bids and keyword recommendations #28002

midavadim commented Jul 6, 2023 •

edited

github-actions bot commented Jul 6, 2023 •

edited by midavadim

midavadim commented Jul 6, 2023 •

edited by github-actions bot

octavia-squidington-iii commented Jul 6, 2023

lazebnyi left a comment

octavia-squidington-iii commented Jul 6, 2023

midavadim commented Jul 6, 2023

octavia-squidington-iii commented Jul 6, 2023

octavia-squidington-iii commented Jul 6, 2023

🎉 Amazon Ads - new streams for bids and keyword recommendations #28002

🎉 Amazon Ads - new streams for bids and keyword recommendations #28002

Conversation

midavadim commented Jul 6, 2023 • edited

What

Recommended reading order

🚨 User Impact 🚨

github-actions bot commented Jul 6, 2023 • edited by midavadim

Before Merging a Connector Pull Request

midavadim commented Jul 6, 2023 • edited by github-actions bot

octavia-squidington-iii commented Jul 6, 2023

source-amazon-ads test report (commit 9a7e9b61a2) - ✅

lazebnyi left a comment

Choose a reason for hiding this comment

octavia-squidington-iii commented Jul 6, 2023

source-amazon-ads test report (commit 9a7e9b61a2) - ✅

midavadim commented Jul 6, 2023

octavia-squidington-iii commented Jul 6, 2023

source-amazon-ads test report (commit 10b52eb9f7) - ✅

octavia-squidington-iii commented Jul 6, 2023

source-amazon-ads test report (commit d178fbaa41) - ✅

midavadim commented Jul 6, 2023 •

edited

github-actions bot commented Jul 6, 2023 •

edited by midavadim

midavadim commented Jul 6, 2023 •

edited by github-actions bot

source-amazon-ads test report (commit `9a7e9b61a2`) - ✅

source-amazon-ads test report (commit `9a7e9b61a2`) - ✅

source-amazon-ads test report (commit `10b52eb9f7`) - ✅

source-amazon-ads test report (commit `d178fbaa41`) - ✅