Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Square: fix display order of spec fields #28019

Merged
merged 4 commits into from Jul 10, 2023
Merged

🐛 Source Square: fix display order of spec fields #28019

merged 4 commits into from Jul 10, 2023
+4 −3

Conversation

ParthG21
Copy link
Contributor

@ParthG21 ParthG21 commented Jul 6, 2023 •
edited

What

resolved: #25158

How

Removed comma from the value of order field for square source connector specification, which was causing it to be a String instead of an Integer.

@ParthG21
Removed comma from the value of order field for square source connect…
2f70e16 
…or specification, which was causing it to be a String instead of an Integer
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited by sh4sh

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Jul 7, 2023
@sh4sh
Copy link
Contributor

sh4sh commented Jul 10, 2023 •
edited

Nice catch! Confirmed they are showing out of order in latest, start_date should appear first but since it doesn't have a valid order field it's dropped to the end.
Screenshot 2023-07-10 at 12 54 58 PM

After this change, the spec will be ordered as intended:
Screenshot 2023-07-10 at 2 33 54 PM

@sh4sh
Copy link
Contributor

sh4sh commented Jul 10, 2023 •
edited

This PR is a patch version change. We need to increment the connector version in its dockerfile and metadata.yaml, and also add a changelog entry to its doc.

@sh4sh sh4sh changed the title Removed comma from the value of order field for square source connector specification, which was causing it to be a String instead of an Integer 🐛 Source Square: Removed comma from the value of order field for square source connector specification, which was causing it to be a String instead of an Integer Jul 10, 2023
@sh4sh sh4sh changed the title 🐛 Source Square: Removed comma from the value of order field for square source connector specification, which was causing it to be a String instead of an Integer 🐛 Source Square: fix display order of spec fields Jul 10, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 10, 2023
@sh4sh sh4sh mentioned this pull request Jul 10, 2023
Closed
@sh4sh sh4sh merged commit 67a8c05 into airbytehq:master Jul 10, 2023
45 of 50 checks passed
@sh4sh
Copy link
Contributor

sh4sh commented Jul 10, 2023

Thanks for your contribution!

efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@ParthG21 @sh4sh @efimmatytsin
🐛 Source Square: fix display order of spec fields (airbytehq#28019)
ef12a58 
* Removed comma from the value of order field for square source connector specification, which was causing it to be a String instead of an Integer

* increment connector version

* add changelog entry

---------

Co-authored-by: Sunny Hashmi <6833405+sh4sh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh4sh sh4sh sh4sh approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/square team/tse Technical Support Engineers
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect value for order field for Square source connector specification.
5 participants
@ParthG21 @CLAassistant @sh4sh @marcosmarxm @octavia-squidington-iii